Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestMkdirStickyUmask failed in github code space #62684

Closed
qiulaidongfeng opened this issue Sep 17, 2023 · 4 comments
Closed

os: TestMkdirStickyUmask failed in github code space #62684

qiulaidongfeng opened this issue Sep 17, 2023 · 4 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@qiulaidongfeng
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
tip

Does this issue reproduce with the latest release?

yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/codespace/.cache/go-build"
GOENV="/home/codespace/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/workspaces/go/src/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build17331257=/tmp/go-build -gno-record-gcc-switches"

What did you do?

cd src
./all.bash

What did you expect to see?

Test passed.

What did you see instead?

--- FAIL: TestMkdirStickyUmask (0.00s)
os_unix_test.go:271: unexpected mode dtrwxr-xr--
FAIL os 0.691s
@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2023

I suspect that this is an ACL problem.

Per https://man7.org/linux/man-pages/man2/umask.2.html:

if the parent directory has a default ACL (see acl(5)), the umask is ignored, the default ACL is inherited, the permission bits are set based on the inherited ACL, and permission bits absent in the mode argument are turned off.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Sep 18, 2023
@bcmills bcmills added this to the Go1.22 milestone Sep 18, 2023
@bcmills bcmills self-assigned this Sep 18, 2023
@gopherbot
Copy link

Change https://go.dev/cl/529115 mentions this issue: os: in TestMkdirStickyUmask, create a non-sticky directory as a control

@bcmills
Copy link
Contributor

bcmills commented Sep 18, 2023

@qiulaidongfeng, can you confirm whether https://go.dev/cl/529115 will fix this failure?

@qiulaidongfeng
Copy link
Contributor Author

The test has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @qiulaidongfeng