Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: slow to compile 17,000 line switch statement? [1.21 backport] #62668

Closed
gopherbot opened this issue Sep 15, 2023 · 2 comments
Closed

cmd/compile: slow to compile 17,000 line switch statement? [1.21 backport] #62668

gopherbot opened this issue Sep 15, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.2

Comments

@gopherbot
Copy link

@randall77 requested issue #62604 to be considered for backport to the next 1.21 minor release.

@gopherbot Please open a backport issue for 1.21.

This is a bug in the compiler that causes unreasonably slow compilation on some large functions.

I'm leaning towards backporting the CL for this issue, as it might be pretty painful, even if it isn't a correctness bug.
The CL itself is super safe.
Happy to hear other opinions though.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 15, 2023
@gopherbot gopherbot mentioned this issue Sep 15, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 15, 2023
@gopherbot gopherbot added this to the Go1.21.2 milestone Sep 15, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/528795 mentions this issue: [release-branch.go1.21] cmd/compile: reset memcombine correctly between basic blocks

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Sep 20, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 20, 2023
@gopherbot
Copy link
Author

Closed by merging 41d71a5 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Sep 25, 2023
@randall77 @thanm
[release-branch.go1.21] cmd/compile: reset memcombine correctly betwe…
41d71a5 
…en basic blocks

Not sure why this bug didn't cause a complete failure, but it
certainly makes for doing a lot more work than is necessary.

Fixes #62668

Change-Id: If0be4acb6eafc3d7eeb42d2f4263c21b4e6e1c7d
Reviewed-on: https://go-review.googlesource.com/c/go/+/527699
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 08cdfd0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/528795
Reviewed-by: Keith Randall <khr@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 25, 2023
@randall77 @bradfitz
[release-branch.go1.21] cmd/compile: reset memcombine correctly betwe…
d3b1376 
…en basic blocks

Not sure why this bug didn't cause a complete failure, but it
certainly makes for doing a lot more work than is necessary.

Fixes golang#62668

Change-Id: If0be4acb6eafc3d7eeb42d2f4263c21b4e6e1c7d
Reviewed-on: https://go-review.googlesource.com/c/go/+/527699
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 08cdfd0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/528795
Reviewed-by: Keith Randall <khr@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.2
Development

No branches or pull requests
2 participants
@gopherbot @joedian