Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/crypto/ssh: expose missing none authmethod #62657

Open
tg123 opened this issue Sep 15, 2023 · 5 comments
Open

proposal: x/crypto/ssh: expose missing none authmethod #62657

tg123 opened this issue Sep 15, 2023 · 5 comments
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone

Comments

@tg123
Copy link

tg123 commented Sep 15, 2023

no api to generate none AuthMethod
expose none to public

@tg123 tg123 added the Proposal label Sep 15, 2023
@gopherbot gopherbot added this to the Proposal milestone Sep 15, 2023
@seankhliao seankhliao changed the title proposal: x/crypto/ssh expose missing none authmethod proposal: x/crypto/ssh: expose missing none authmethod Sep 15, 2023
@seankhliao seankhliao added the Proposal-Crypto Proposal related to crypto packages or other security issues label Sep 15, 2023
@ianlancetaylor
Copy link
Contributor

In https://go.dev/cl/528637 the suggested API is

// None return an AuthMethod using "none" authentication defined in RFC 4252 section 5.2.
func None() AuthMethod {

@tg123
Copy link
Author

tg123 commented Sep 15, 2023

golang/crypto#272

@hanwen
Copy link
Contributor

hanwen commented Sep 21, 2023

Can you explain why you want to expose the None authmethod? TestClientAuthNone shows how to use the None auth method; it doesn't need client-side configuration.

@tg123
Copy link
Author

tg123 commented Sep 23, 2023

@hanwen allow client side to send non-auth on their own like password or key
for example, send non after password. this is useful in special client impl

@drakkan
Copy link
Member

drakkan commented Sep 24, 2023

@tg123 thanks for this proposal, can you please provide a real use case for this? For example a server that requires sending the none auth method after the password.

The none auth method is generally used initially just to list the authentication methods that can continue and this is what we already do in our client implementation. As you can see here, none auth is implicitly added to the configured authentication methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Status: Incoming
Development

No branches or pull requests

6 participants