Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/crypto/ssh/knownhosts: create from io.Reader #62656

Open
tg123 opened this issue Sep 15, 2023 · 2 comments · May be fixed by golang/crypto#269
Open

proposal: x/crypto/ssh/knownhosts: create from io.Reader #62656

tg123 opened this issue Sep 15, 2023 · 2 comments · May be fixed by golang/crypto#269
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone
Proposal

Comments

@tg123
Copy link

tg123 commented Sep 15, 2023

knownhosts.New accept file on local disk only now, which is not flexible for parsing knowhosts inside memory or load from other media.

Proposal for new API

func NewFromReader(r io.Reader) (ssh.HostKeyCallback, error)

to load knowhosts from io.Reader
@tg123 tg123 added the Proposal label Sep 15, 2023
@gopherbot gopherbot added this to the Proposal milestone Sep 15, 2023
@tg123 tg123 linked a pull request Sep 15, 2023 that will close this issue
Open
@ianlancetaylor ianlancetaylor added the Proposal-Crypto Proposal related to crypto packages or other security issues label Sep 15, 2023
@ianlancetaylor
Copy link
Contributor

CC @golang/security

@seankhliao seankhliao changed the title proposal: x/crypto/ssh/knownhosts create from io.reader proposal: x/crypto/ssh/knownhosts: create from io.Reader Sep 15, 2023
@drakkan
Copy link
Member

drakkan commented Sep 24, 2023

I like this proposal, just wondering if we should allow multiple readers similarly to knownhosts.New where we accept multiple files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

Successfully merging a pull request may close this issue.

ssh/knownhosts: knownhost to support io.reader tg123/sshpiper.crypto
4 participants
@tg123 @drakkan @ianlancetaylor @gopherbot