Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: too many goroutines running after net/http tests #62643

Closed
gopherbot opened this issue Sep 14, 2023 · 7 comments
Closed

net/http: too many goroutines running after net/http tests #62643

gopherbot opened this issue Sep 14, 2023 · 7 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@gopherbot
Copy link

gopherbot commented Sep 14, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test` && log ~ `^net/http_test\.testServerGracefulClose\.func` && date < "2023-09-20"

Issue created automatically to collect these failures.

Example (log):

PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3139 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13861
	/tmp/buildlet/go/src/net/http/serve_test.go:3137 +0x30f

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 14, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == ""
2023-09-14 13:19 darwin-amd64-longtest go@9ee23e97 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3139 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13861
	/tmp/buildlet/go/src/net/http/serve_test.go:3137 +0x30f

— watchflakes

@cherrymui cherrymui changed the title net/http: unrecognized failures net/http: too many goroutines running after net/http tests Sep 14, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test`
2023-09-14 19:44 darwin-amd64-longtest go@e356aa65 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13765
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f

— watchflakes

@bcmills bcmills self-assigned this Sep 15, 2023
@bcmills bcmills added this to the Go1.22 milestone Sep 15, 2023
@bcmills bcmills added Proposal-FinalCommentPeriod Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed Proposal-FinalCommentPeriod labels Sep 15, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 15, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/528398 mentions this issue: net/http: avoid leaking goroutines when TestServerGracefulClose retries

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test` && log ~ `^net/http_test\.testServerGracefulClose\.func` && date < "2023-09-20"
2023-09-15 12:45 darwin-amd64-longtest go@a9cfbec1 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13816
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f
2023-09-15 12:45 darwin-amd64-longtest go@00073c25 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13882
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test` && log ~ `^net/http_test\.testServerGracefulClose\.func` && date < "2023-09-20"
2023-09-15 15:22 darwin-amd64-longtest go@72868003 net/http (log) 
2023/09/15 11:56:11 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0002578e0 127.0.0.1:62816 in state active
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13902
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test` && log ~ `^net/http_test\.testServerGracefulClose\.func` && date < "2023-09-20"
2023-09-15 16:16 darwin-amd64-longtest go@5914f6a4 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 14055
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "" && `Too many goroutines running after net/http test` && log ~ `^net/http_test\.testServerGracefulClose\.func` && date < "2023-09-20"
2023-09-15 21:33 darwin-amd64-longtest go@08cdfd06 net/http (log) 
PASS
Too many goroutines running after net/http test(s).
1 instances of:
net/http_test.testServerGracefulClose.func1.2()
	/tmp/buildlet/go/src/net/http/serve_test.go:3142 +0x4a
created by net/http_test.testServerGracefulClose.func1 in goroutine 13768
	/tmp/buildlet/go/src/net/http/serve_test.go:3140 +0x30f

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@bcmills @gopherbot