Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestVariousDeadlines failure on Windows LUCI builder #62616

Open
bcmills opened this issue Sep 13, 2023 · 5 comments
Open

net: TestVariousDeadlines failure on Windows LUCI builder #62616

bcmills opened this issue Sep 13, 2023 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 13, 2023 

#!watchflakes
post <- pkg == "net" && test == "TestVariousDeadlines" && `connectex: A connection attempted failed`

From https://ci.chromium.org/ui/p/golang/builders/try-workers/gotip-windows-amd64-test_only/b8770051282862599649/overview:

=== RUN   TestVariousDeadlines
=== PAUSE TestVariousDeadlines
=== CONT  TestVariousDeadlines
    timeout_test.go:1003: 1ns 0/1
    timeout_test.go:1019: 1ns 0/1: good timeout after 82.7µs; 0 bytes
    timeout_test.go:1003: 2ns 0/1
    timeout_test.go:1019: 2ns 0/1: good timeout after 891.3µs; 0 bytes
    timeout_test.go:1003: 5ns 0/1
    timeout_test.go:1019: 5ns 0/1: good timeout after 72µs; 0 bytes
    timeout_test.go:1003: 50ns 0/1
    timeout_test.go:1019: 50ns 0/1: good timeout after 833.5µs; 0 bytes
    timeout_test.go:1003: 100ns 0/1
    timeout_test.go:1007: dial tcp 127.0.0.1:56139: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
--- FAIL: TestVariousDeadlines (1.03s)

See previously #19519.

(CC @ianlancetaylor @neild)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 13, 2023
@bcmills bcmills added this to the Backlog milestone Sep 13, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Sep 13, 2023

Given that it's on windows, I wonder if this is related to https://go.dev/cl/495875 / #23366.

(attn @qmuntal; CC @golang/windows)

@bcmills
Copy link
Contributor Author

bcmills commented Sep 13, 2023

If I run the test repeatedly on a gomote I appear to be able to drive it into port exhaustion instead. 😅

gopher@GOLANG-BUILDLET C:\workdir\go\src>..\bin\go test net -run=TestVariousDeadlines -
short -failfast -count=1000
--- FAIL: TestVariousDeadlines (0.01s)
    timeout_test.go:1003: 1ns 0/1
    timeout_test.go:1007: dial tcp 127.0.0.1:50212: connectex: Only one usage of each s
ocket address (protocol/network address/port) is normally permitted.
FAIL
FAIL    net     0.038s
FAIL

@qmuntal
Copy link
Contributor

qmuntal commented Sep 14, 2023

Given that it's on windows, I wonder if this is related to https://go.dev/cl/495875 / #23366.

Still haven't investigated this, but I wonder what makes you think that? That CL is already 4 month old, and this is the first time I see this watchflakes report. Has something changed in between that could make a latent bug introduced in CL 495875 easier to reproduce?

@bcmills
Copy link
Contributor Author

bcmills commented Sep 14, 2023

Has something changed in between that could make a latent bug introduced in CL 495875 easier to reproduce?

The LUCI builders are running on different machines, slightly different configurations, and perhaps different VM images from the older dashboard builders. It is possible that some variation in either the configuration or timing has exposed a bug.

(It is also possible that some aspect of the LUCI builder configuration is subtly wrong, or perhaps something else on the machine is somehow interfering with the test.)

@bcmills
Copy link
Contributor Author

bcmills commented Sep 18, 2023 •
edited

Two more on https://go.dev/cl/529095:

(CC @golang/release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@qmuntal @bcmills