Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: package removal request for github.com/mend-toolkit/mend-log-parser/* #62602

Closed
kyallanum-MND opened this issue Sep 12, 2023 · 5 comments
Closed

x/pkgsite: package removal request for github.com/mend-toolkit/mend-log-parser/* #62602

kyallanum-MND opened this issue Sep 12, 2023 · 5 comments
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@kyallanum-MND
Copy link

What is the path of the package that you would like to have removed?

github.com/mend-toolkit/mend-log-parser/bll
github.com/mend-toolkit/mend-log-parser/models
github.com/mend-toolkit/mend-log-parser/utils

Are you the owner of this package?

Yes

What is the reason that you could not retract this package instead?

All three of these were sub-modules I had on the original package. I removed the submodules as they are only intended to work with this package. Therefore I would like them removed so they don't show on pkg.go.dev.

I haven't retracted them as they are sub-modules that no longer exist in my go.mod file.
@kyallanum-MND kyallanum-MND added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Sep 12, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 12, 2023
@seankhliao seankhliao changed the title x/pkgsite: package removal request for mend-log-parser/* x/pkgsite: package removal request for github.com/mend-toolkit/mend-log-parser/* Sep 12, 2023
@seankhliao
Copy link
Member

please use the retract directive, a retraction doesn't need to be published on the main branch, you can recreate the go.mod files on a temporary branch with the appropriate tags.

@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 12, 2023
@kyallanum-MND
Copy link
Author

kyallanum-MND commented Sep 12, 2023 •
edited

@seankhliao I did as you suggested, but I get an error when running go list -m github.com/mend-toolkit/mend-log-parser/v23@v23.9.1:

.\go.mod:14:2: retract github.com/mend-toolkit/mend-log-parser/v23: version "bll/v0.1.0" invalid: version "bll/v0.1.0" invalid: disallowed version string       
.\go.mod:15:2: retract github.com/mend-toolkit/mend-log-parser/v23: version "models/v0.1.0" invalid: version "models/v0.1.0" invalid: disallowed version string 
.\go.mod:16:2: retract github.com/mend-toolkit/mend-log-parser/v23: version "utils/v0.1.0" invalid: version "utils/v0.1.0" invalid: disallowed version string

When checking on pkg.go.dev I see this still.

I'm not supposed to be using the full sub-module name like:
github.com/mend-toolkit/mend-log-parser/bll
am I?

Here's a link to my go.mod file

@seankhliao
Copy link
Member

retractions have to be published in the module being retracted, ie:
create models/go.mod with:

module github.com/mend-toolkit/mend-log-parser/models
retract [v0.0.0-0, v0.2.0]

tag the commit with models/v0.2.0, and fetch github.com/mend-toolkit/mend-log-parser/models@v0.2.0.

Go modules have no concept of nesting.

@kyallanum-MND
Copy link
Author

@seankhliao looks like this worked. I get retract messages when attempting to fetch them. Thank you.

I do still see them on pkg.go.dev. Is this expected? Or will they be hidden/removed eventually.

@kyallanum-MND
Copy link
Author

shows as retracted now on pkg.go.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @kyallanum-MND