Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: data race in TestCloseUnblocksRead #62542

Closed
bcmills opened this issue Sep 8, 2023 · 4 comments
Closed

net: data race in TestCloseUnblocksRead #62542

bcmills opened this issue Sep 8, 2023 · 4 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 8, 2023 

#!watchflakes
post <- pkg == "net" && log ~ `WARNING: DATA RACE` && log ~ `net\.TestCloseUnblocksRead`
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 8, 2023
@bcmills bcmills added this to the Backlog milestone Sep 8, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Sep 8, 2023

(Found in https://build.golang.org/log/df423ba473396c5e145c7a6694ab25e20c44375b.)

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && log ~ `WARNING: DATA RACE` && log ~ `net\.TestCloseUnblocksRead`
2023-08-29 20:19 linux-s390x-ibm-race go@ad74bc4a net (log) 
2023/08/30 04:11:25 killing splice client after 5 second shutdown timeout
PASS
==================
WARNING: DATA RACE
Write at 0x00000069a3b8 by main goroutine:
  net.uninstallTestHooks()
      /data/golang/workdir/go/src/net/main_unix_test.go:39 +0xc9
  sync.(*Once).doSlow()
      /data/golang/workdir/go/src/sync/once.go:74 +0xf3
  sync.(*Once).Do()
...
  net.withTCPConnPair()
      /data/golang/workdir/go/src/net/net_test.go:437 +0x26f
  net.TestCloseUnblocksRead()
      /data/golang/workdir/go/src/net/net_test.go:524 +0x5f
  testing.tRunner()
      /data/golang/workdir/go/src/testing/testing.go:1595 +0x23d
  testing.(*T).Run.gowrap1()
      /data/golang/workdir/go/src/testing/testing.go:1648 +0x8d
==================
Found 1 data race(s)

— watchflakes

@gopherbot
Copy link

Change https://go.dev/cl/526977 mentions this issue: net: synchronize calls to Close in the withTCPConnPair test helper

@bcmills bcmills self-assigned this Sep 8, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 8, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 8, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.22 Sep 8, 2023
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && log ~ `WARNING: DATA RACE` && log ~ `net\.TestCloseUnblocksRead`
2023-09-08 19:03 linux-s390x-ibm-race go@45d3d100 net (log) 
2023/09/09 05:31:52 killing splice client after 5 second shutdown timeout
PASS
==================
WARNING: DATA RACE
Read at 0x00000069a358 by goroutine 2114:
  internal/poll.(*SysFile).destroy()
      /data/golang/workdir/go/src/internal/poll/fd_unixjs.go:24 +0xf5
  internal/poll.(*FD).destroy()
      /data/golang/workdir/go/src/internal/poll/fd_unix.go:81 +0xae
  internal/poll.(*FD).decref()
...
  net.withTCPConnPair()
      /data/golang/workdir/go/src/net/net_test.go:437 +0x26f
  net.TestCloseUnblocksRead()
      /data/golang/workdir/go/src/net/net_test.go:524 +0x5f
  testing.tRunner()
      /data/golang/workdir/go/src/testing/testing.go:1595 +0x23d
  testing.(*T).Run.gowrap1()
      /data/golang/workdir/go/src/testing/testing.go:1648 +0x8d
==================
Found 1 data race(s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@bcmills @gopherbot