Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/stringer: TestEndToEnd failures on RISCV64 #62534

Closed
gopherbot opened this issue Sep 8, 2023 · 4 comments
Closed

x/tools/cmd/stringer: TestEndToEnd failures on RISCV64 #62534

gopherbot opened this issue Sep 8, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Sep 8, 2023 •
edited by bcmills 

#!watchflakes
post <- repo == "tools" && goarch == "riscv64" && (test == "TestEndToEnd" || (pkg == "command-line-arguments" && test == ""))

(pkg == "golang.org/x/tools/cmd/stringer" but the log parser confused)

Issue created automatically to collect these failures.

Example (log):

stringer: error: 0 packages found
--- FAIL: TestEndToEnd (16.73s)
    endtoend_test.go:81: run: prime.go Prime
    endtoend_test.go:81: run: number.go Number
    endtoend_test.go:81: run: unum.go Unum
    endtoend_test.go:81: run: unum2.go Unum2
    endtoend_test.go:81: run: num.go Num
    endtoend_test.go:81: run: cgo.go Cgo
    endtoend_test.go:81: exit status 1
Note: the following messages should indicate an out-of-bounds compiler error

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- repo == "tools" && section == "go test -short -timeout=40m0s ./..." && test == "TestEndToEnd"
2023-09-07 12:58 linux-riscv64-unmatched tools@01224cd5 go@a35bb44a TestEndToEnd (log) 
stringer: error: 0 packages found
--- FAIL: TestEndToEnd (16.73s)
    endtoend_test.go:81: run: prime.go Prime
    endtoend_test.go:81: run: number.go Number
    endtoend_test.go:81: run: unum.go Unum
    endtoend_test.go:81: run: unum2.go Unum2
    endtoend_test.go:81: run: num.go Num
    endtoend_test.go:81: run: cgo.go Cgo
    endtoend_test.go:81: exit status 1
Note: the following messages should indicate an out-of-bounds compiler error
2023-09-07 17:02 linux-riscv64-unmatched tools@b0cdf010 go@834a6f9a TestEndToEnd (log) 
stringer: error: 0 packages found
--- FAIL: TestEndToEnd (16.28s)
    endtoend_test.go:81: run: prime.go Prime
    endtoend_test.go:81: run: number.go Number
    endtoend_test.go:81: run: unum.go Unum
    endtoend_test.go:81: run: unum2.go Unum2
    endtoend_test.go:81: run: num.go Num
    endtoend_test.go:81: run: cgo.go Cgo
    endtoend_test.go:81: exit status 1
Note: the following messages should indicate an out-of-bounds compiler error

— watchflakes

@cherrymui cherrymui changed the title go test -short -timeout=40m0s ./...: TestEndToEnd failures x/tools/cmd/stringer: TestEndToEnd failures on RISCV64 Sep 8, 2023
@cherrymui cherrymui added this to the Unreleased milestone Sep 8, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 8, 2023
@cherrymui cherrymui mentioned this issue Sep 8, 2023
Closed
@bcmills
Copy link
Contributor

bcmills commented Sep 8, 2023

This is probably the same root cause as #62536, but the stringer test ought to give better logging either way.

@gopherbot
Copy link
Author

Change https://go.dev/cl/526172 mentions this issue: cmd/stringer: log more information in tests

gopherbot pushed a commit to golang/tools that referenced this issue Sep 8, 2023
@gopherbot
cmd/stringer: log more information in tests
627959a 
Also associate the stderr and stdout output of subprocesses more
clearly with the specific test.

For golang/go#62534.

Change-Id: I6768f2d8d60e21d4d6465208c17b542691a3f803
Reviewed-on: https://go-review.googlesource.com/c/tools/+/526172
Commit-Queue: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 8, 2023
@gopherbot
Copy link
Author

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @cherrymui