Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/poller: TestSetAndLoadExperiments failures #62530

Closed
gopherbot opened this issue Sep 8, 2023 · 3 comments
Closed

x/pkgsite/internal/poller: TestSetAndLoadExperiments failures #62530

gopherbot opened this issue Sep 8, 2023 · 3 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestSetAndLoadExperiments"

Issue created automatically to collect these failures.

Example (log):

2023/08/31 15:14:21 Info: caching response of length 25 for /A
2023/08/31 15:14:21 Debug: serving "/A" from cache
2023/08/31 15:14:21 Info: caching response of length 25 for /A
2023/08/31 15:14:21 Debug: serving "/A" from cache
--- FAIL: TestSetAndLoadExperiments (0.30s)
    experiment_test.go:75: experiment "test-feature" should not be active
2023/08/31 15:14:22 Error: middleware.Panic: panic!

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 8, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 8, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/poller" && test == "TestSetAndLoadExperiments"
2023-08-31 19:09 linux-s390x-ibm pkgsite@12a45f89 go@e3ba569c x/pkgsite/internal/poller.TestSetAndLoadExperiments (log) 
2023/08/31 15:14:21 Info: caching response of length 25 for /A
2023/08/31 15:14:21 Debug: serving "/A" from cache
2023/08/31 15:14:21 Info: caching response of length 25 for /A
2023/08/31 15:14:21 Debug: serving "/A" from cache
--- FAIL: TestSetAndLoadExperiments (0.30s)
    experiment_test.go:75: experiment "test-feature" should not be active
2023/08/31 15:14:22 Error: middleware.Panic: panic!

— watchflakes

@bcmills bcmills added pkgsite Testing An issue that has been verified to require only test changes, not just a test failure. labels Sep 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Sep 8, 2023

This test is timing-sensitive and uses a hard-coded Sleep:
https://cs.opensource.google/go/x/pkgsite/+/master:internal/middleware/experiment_test.go;l=72;drc=f93c7b3d884a8dce4ec0696b5c528e83f5e753fb

@bcmills bcmills self-assigned this Sep 8, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 8, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Sep 13, 2023

Fixed by https://go.dev/cl/524800. (I typo'd the repo issue reference. 😅)

@bcmills bcmills closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot