Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: InvertFlags should never make it to codegen v100 = InvertFlags v123 [1.21 backport] #62506

Closed
gopherbot opened this issue Sep 7, 2023 · 3 comments
Closed

cmd/compile: internal compiler error: InvertFlags should never make it to codegen v100 = InvertFlags v123 [1.21 backport] #62506

gopherbot opened this issue Sep 7, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.2

Comments

@gopherbot
Copy link

@randall77 requested issue #62469 to be considered for backport to the next 1.21 minor release.

@gopherbot please open a backport issue for 1.21.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 7, 2023
@gopherbot gopherbot mentioned this issue Sep 7, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 7, 2023
@gopherbot gopherbot added this to the Go1.21.2 milestone Sep 7, 2023
@randall77
Copy link
Contributor

This can cause an ICE that can be hard to work around.

@gopherbot
Copy link
Author

Change https://go.dev/cl/526521 mentions this issue: [release-branch.go1.21] cmd/compile: absorb InvertFlags into Noov comparisons

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Sep 20, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 20, 2023
gopherbot pushed a commit that referenced this issue Sep 25, 2023
@randall77 @thanm
[release-branch.go1.21] cmd/compile: absorb InvertFlags into Noov com…
a15ef1b 
…parisons

Unfortunately, there isn't a single op that provides the resulting
computation.
At least, I couldn't find one.

Fixes #62506

Change-Id: I236f3965b827aaeb3d70ef9fe89be66b116494f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/526276
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@google.com>
(cherry picked from commit fb5bdb4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/526521
Reviewed-by: Than McIntosh <thanm@google.com>
@gopherbot
Copy link
Author

Closed by merging a15ef1b to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.2
Development

No branches or pull requests
4 participants
@randall77 @gopherbot @joedian and others