You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
x/build/cmd/relui: the entire tree state except the VERSION file is checked during release tagging; go1.19.13 got tagged at commit prior to VERSION file update
#62481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Publishing head was the commit just before the VERSION file. Its tree content is exactly the right content, but VERSION file isn't updated yet.
Then "Mail version CL" tries to mail and wait for a CL to land.
If that task happens result in no CL being mailed (e.g., because tip of the release branch already has the VERSION file updated to its intended content), the AwaitCL will return publishingHead as is.
It should instead make sure that the publishingHead commit contains the intended VERSION file content, and if it doesn't, read the branch head again and see if (or one if its parents) does. Otherwise it's correct for it to fail until the tip of the release branch is corrected.
(It's good that the most amount of deviation between intended tagged commit and actual tagged commit could've been the VERSION file only, and no other file. After fixing this issue, the VERSION file will also be verified and require to match exactly.)
dmitshur
changed the title
x/build/cmd/relui: go1.19.13 is tagged at wrong commit
x/build/cmd/relui: the entire tree state except the VERSION file is checked during release tagging; go1.19.13 got tagged at commit prior to VERSION file update
Sep 6, 2023
For the one-off Go 1.19.13 release, it is tagged at a commit before the version CL submitted. It is tagged at caca5f1, but it should be 619b8fd.
We're going to move the tag manually to the correct commit.
Also filing an issue to investigate any logic bug in relui that could cause this.
The text was updated successfully, but these errors were encountered: