Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/metrics: /gc/scan* metrics return zero [1.21 backport] #62478

Closed
gopherbot opened this issue Sep 6, 2023 · 3 comments
Closed

runtime/metrics: /gc/scan* metrics return zero [1.21 backport] #62478

gopherbot opened this issue Sep 6, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.2

Comments

@gopherbot
Copy link

@mknyszek requested issue #62477 to be considered for backport to the next 1.21 minor release.

@gopherbot please open a backport issue for Go 1.21.

This issue means that some new metrics just don't work, and there's no workaround. Although the severity of the issue is quite low, the fix is also very safe and includes a test.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 6, 2023
@gopherbot gopherbot mentioned this issue Sep 6, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 6, 2023
@gopherbot gopherbot modified the milestones: Go1.21.1, Go1.21.2 Sep 6, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/526116 mentions this issue: [release-branch.go1.21] runtime/metrics: fix /gc/scan/* metrics

@cherrymui
Copy link
Member

Approved. Looks pretty safe.

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Sep 6, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 6, 2023
@gopherbot
Copy link
Author

Closed by merging cd66ca0 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Sep 11, 2023
@Gandem @gopherbot
[release-branch.go1.21] runtime/metrics: fix /gc/scan/* metrics
cd66ca0 
In the existing implementation, all /gc/scan/* metrics are
always equal to 0 due to the dependency on gcStatDep not being
set. This leads to gcStatAggregate always containing zeros, and
always reporting 0 for those metrics.

Also, add a test to ensure that /gc/scan/* metrics are not empty.

For #62477.
Fixes #62478.

Change-Id: I67497347d50ed5c3ce1719a18714c062ec938cab
Reviewed-on: https://go-review.googlesource.com/c/go/+/526116
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@hawkingrei hawkingrei mentioned this issue Oct 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.2
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui