Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: longtest extra slowbot runs should count against prequal #62476

Closed
thanm opened this issue Sep 6, 2023 · 4 comments
Closed

x/build: longtest extra slowbot runs should count against prequal #62476

thanm opened this issue Sep 6, 2023 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@thanm
Copy link
Contributor

thanm commented Sep 6, 2023

For a recent CL, I kicked off the LUCI trybots and requested an additional slowbot run for the linux-amd64-longtest builder.

I noticed that I got an "all checks passed" email from LUCI before the longtest slowbot run had completed-- it seems that the additional slowbot runs are decoupled from conditions used to decide whether the CL passes prequal, which is a little different from the way things worked pre-LUCI.

It would be nice to have a way to tell LUCI something to the effect of "don't add prequal +1 to this CL unless a specific set of slowbots also pass" (this is especially important for things like cmd/go CLs or linker CLs that touch arch-specific code).

Thanks.

cc @golang/release
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 6, 2023
@heschi
Copy link
Contributor

heschi commented Sep 6, 2023

Looks like the way to do this is to specify Cq-Include-Trybots: in the CL description. You can go through the "Choose Tryjobs" interface, then copy the line at the bottom of the dialog box into the description. Does that work for you? The advantage is that you don't have to remember to do it at each patchset.

@thanm
Copy link
Contributor Author

thanm commented Sep 6, 2023

Thanks that recipe SGTM, thanks (don't think I would have discovered that on my own).

I see from the docs for Cq-Include-Trybots:

The format for specifying the list of builders is
project/bucket:builder1,builder2;another_proj/bucket: builder3.

So for our case, what should I fill in for project and bucket? Builder I assume should be "linux-amd64-longtest"? Or should it be "gotip-linux-amd64-longtest"?

@thanm
Copy link
Contributor Author

thanm commented Sep 6, 2023

Ah never mind, I see what you mean now, with the business of using the dialog box. yeah, that seems like it should work.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 7, 2023
@heschi
Copy link
Contributor

heschi commented Sep 19, 2023

This seems like a reasonable result; if there's more to do feel free to reopen.

@heschi heschi closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @thanm @heschi