Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj: stack bounds check prologue can be preemptible and resume at entry #62433

Closed
zhouguangyuan0718 opened this issue Sep 3, 2023 · 2 comments
Closed

cmd/internal/obj: stack bounds check prologue can be preemptible and resume at entry #62433

zhouguangyuan0718 opened this issue Sep 3, 2023 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.

Comments

@zhouguangyuan0718
Copy link
Contributor

The stack bounds check prologue is nonpreemptible now. But actually, if we mark the unsafepoint of it as "RestartAtEntry", it can be async preempted safely. After async preempted, we just need resume it at the entry of the function.

And according to the comment in CL 208126:

TODO: the split-stack function prologue is currently not async
preemptible. We could use this mechanism, preempt it and restart
at the function entry.

It will be reasonable to do this.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 3, 2023
@gopherbot
Copy link

Change https://go.dev/cl/525316 mentions this issue: cmd/internal/obj: mark stack bounds check prologue preemptible

@cherrymui
Copy link
Member

This doesn't really need an issue. You can just send a CL (as you already did) and we can go from there (and have the discussion in one place). Thanks.

@cherrymui cherrymui closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gopherbot @cherrymui @zhouguangyuan0718