Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/mobile: start using OpenGL ES 3 instead of OpenGL ES 2 on Android #62413

Open
hajimehoshi opened this issue Sep 1, 2023 · 3 comments
Open

proposal: x/mobile: start using OpenGL ES 3 instead of OpenGL ES 2 on Android #62413

hajimehoshi opened this issue Sep 1, 2023 · 3 comments
Labels
mobile Android, iOS, and x/mobile Proposal
Milestone
Proposal

Comments

@hajimehoshi
Copy link
Member

hajimehoshi commented Sep 1, 2023 •
edited

Now OpenGL ES 3 is not supported by gomobile-build as it was troublesome to detect whether a device supports GL ES 3 or not (https://github.com/golang/mobile/blob/7088062f872dd0678a87e8986c67992e9c8855a5/gl/work.h#L5-L10).

IMO, it is already safe to assume that most devices support GL ES 3, and we don't have to detect it. One reason is that ES 3 is supported by Android 5 (https://developer.android.com/guide/topics/graphics/opengl).

By this change, gomobile implementation will be slightly simpler.

What do you think?

/CC @hyangah @dmitshur @crawshaw
@gopherbot gopherbot added this to the Proposal milestone Sep 1, 2023
@hajimehoshi hajimehoshi mentioned this issue Sep 1, 2023
Closed
10 tasks
@dmitshur
Copy link
Contributor

dmitshur commented Sep 1, 2023 •
edited

To clarify, is this proposal to replace OpenGL ES 2 on Android with OpenGL ES 3? That is, to drop 2 and add 3 in its place?

Given Android 5 was released in 2014 and is unsupported since 2016, I can't think of a good reason to object to the change. That said, given the state of x/mobile support and prioritization, I'm not sure who would have time to do the work and code reviews. If it can happen anyway, the change itself seems favorable to me.

@hajimehoshi
Copy link
Member Author

To clarify, is this proposal to replace OpenGL ES 2 on Android with OpenGL ES 3? That is, to drop 2 and add 3 in its place?

I meant to drop 2 and add 3. So, if a device doesn't support ES 3, gomobile would not work there.

@dmitshur dmitshur changed the title proposal: x/mobile: support OpenGL ES 3 on Android proposal: x/mobile: start using OpenGL ES 3 instead of OpenGL ES 2 on Android Sep 1, 2023
@ianlancetaylor
Copy link
Contributor

CC @golang/mobile-admins @golang/android

@hajimehoshi hajimehoshi mentioned this issue Jan 7, 2024
Closed
@dmitshur dmitshur added the mobile Android, iOS, and x/mobile label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mobile Android, iOS, and x/mobile Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
4 participants
@hajimehoshi @dmitshur @ianlancetaylor @gopherbot