-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: TestVMInfo failures #62352
Comments
Found new dashboard test flakes for:
2023-08-29 16:16 darwin-amd64-nocgo go@4e48e467 runtime/pprof.TestVMInfo (log)
|
This test is new during the Go 1.22 cycle (https://go.dev/cl/503919; attn @cosnicolaou @cherrymui). A good starting point would probably be to update the test to log the |
Change https://go.dev/cl/524156 mentions this issue: |
Print Stderr on test failure to track down the intermittent test failure reported in issue #62352. Change-Id: I547a3220dc07d05578dac093d6c028a9103b552a Reviewed-on: https://go-review.googlesource.com/c/go/+/524156 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The new logging is in place, so I've marked this WaitingForInfo to see what turns up after https://go.dev/cl/524936. |
Found new dashboard test flakes for:
2023-09-08 20:37 darwin-arm64-11 go@a742ae49 runtime/pprof.TestVMInfo (log)
|
ok, I see what's going on, and I'll provide a workaround, hopefully today.
…On Fri, Sep 8, 2023 at 2:23 PM GopherBot ***@***.***> wrote:
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "runtime/pprof" && test == "TestVMInfo"
2023-09-08 20:37 darwin-arm64-11 ***@***.*** runtime/pprof.TestVMInfo (log
<https://build.golang.org/log/3523f6558165872a1370b4ab3ad56c301b91c576>)
--- FAIL: TestVMInfo (0.29s)
vminfo_darwin_test.go:61: vmmap failed: Process: pprof.test [15435]
Path: /private/tmp/*/pprof.test
Load Address: 0x100f50000
Identifier: pprof.test
Version: ???
Code Type: ARM64
Parent Process: go [15399]
Date/Time: 2023-09-08 16:41:16.280 -0400
...
=========== ======= ======== ===== ======= ======== ====== ===== =======
TOTAL 2.1G 326.5M 16.0M 0K 0K 0K 0K 355
VIRTUAL RESIDENT DIRTY SWAPPED ALLOCATION BYTES DIRTY+SWAP REGION
MALLOC ZONE SIZE SIZE SIZE SIZE COUNT ALLOCATED FRAG SIZE % FRAG COUNT
=========== ======= ========= ========= ========= ========= ========= ========= ====== ======
DefaultMallocZone_0x10129c000 9216K 64K 64K 0K 209 11K 53K 83% 2
vminfo_darwin_test.go:63: /usr/bin/vmmap 15435: exit status 255
vmmap[15527]: [fatal] child process status could not be determined; exit code unavailable.
— watchflakes <https://go.dev/wiki/Watchflakes>
—
Reply to this email directly, view it on GitHub
<#62352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCMUYHUML7VEDBTEBIHNFDXZOEDPANCNFSM6AAAAAA4DJ3CZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Change https://go.dev/cl/527276 mentions this issue: |
Found new dashboard test flakes for:
2023-10-18 14:46 darwin-amd64-12_0 go@1ec427e7 runtime/pprof.TestVMInfo (log)
|
Well, I'm not sure what to do about this, since it looks as if the CI runner doesn't have the resources to run another subprocess given the error message |
Found new dashboard test flakes for:
2023-11-08 14:13 darwin-amd64-12_0 go@8fb8d0df runtime/pprof.TestVMInfo (log)
|
@cosnicolaou, at the very least, perhaps the test should skip instead of failing if the output matches that failure mode. |
Found new dashboard test flakes for:
2024-04-22 13:29 gotip-darwin-amd64-longtest go@2dddc7ef runtime/pprof.TestVMInfo (log)
|
Found new dashboard test flakes for:
2024-04-22 14:55 gotip-darwin-amd64_14 go@69aa1974 runtime/pprof.TestVMInfo (log)
|
Found new dashboard test flakes for:
2024-10-21 13:40 gotip-darwin-amd64_14 go@c0a126b8 runtime/pprof.TestVMInfo (log)
|
Found new dashboard test flakes for:
2024-10-21 15:56 gotip-darwin-amd64-nocgo go@a1c4fb43 runtime/pprof.TestVMInfo (log)
|
In triage, we're thinking this is actually due to some problems with the tool provided by Apple, and maybe we should just wrap it in retries. |
… On Wed, Nov 13, 2024 at 1:23 PM Michael Knyszek ***@***.***> wrote:
In triage, we're thinking this is actually due to some problems with the
tool provided by Apple, and maybe we should just wrap it in retries.
—
Reply to this email directly, view it on GitHub
<#62352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCMUYF4NYA5HJMSEWRN2FT2AO7O3AVCNFSM6AAAAAA4DJ3CZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUHAYTENZXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@cosnicolaou thanks. Does the CL fix the failures? If so, maybe rebase and get it submitted (it has a merge conflict)? Thanks. |
I've updated the PR to fix the merge conflict.
…On Thu, Nov 14, 2024 at 6:56 AM cherrymui ***@***.***> wrote:
@cosnicolaou <https://github.com/cosnicolaou> thanks. Does the CL fix the
failures? If so, maybe rebase and get it submitted (it has a merge
conflict)? Thanks.
—
Reply to this email directly, view it on GitHub
<#62352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCMUYGKZXH4UD6KOPGAEHL2AS2Z7AVCNFSM6AAAAAA4DJ3CZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGU4DGMBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Found new dashboard test flakes for:
2024-12-19 04:48 gotip-darwin-amd64_12 go@4f0561f9 runtime/pprof.TestVMInfo (log)
|
Change https://go.dev/cl/637995 mentions this issue: |
This change catches an additional error message to trigger skipping the test when the underlying system is failing. Fixes golang#62352 Change-Id: I5c12b20f3e9023597ff89fc905c0646a80ec4811 Reviewed-on: https://go-review.googlesource.com/c/go/+/637995 Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: