Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: http client regression building with js/wasm and running on Chrome: net::ERR_H2_OR_QUIC_REQUIRED [1.21 backport] #62328

Closed
gopherbot opened this issue Aug 28, 2023 · 3 comments
Closed

net/http: http client regression building with js/wasm and running on Chrome: net::ERR_H2_OR_QUIC_REQUIRED [1.21 backport] #62328

gopherbot opened this issue Aug 28, 2023 · 3 comments
Labels
arch-wasm WebAssembly issues CherryPickApproved Used during the release process for point releases OS-JS
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@neild requested issue #61889 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport to 1.21. This is a regression with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 28, 2023
@gopherbot gopherbot mentioned this issue Aug 28, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 28, 2023
@dmitshur
Copy link
Contributor

Approving after discussing with @neild and @johanbrandhorst. There's no workaround, and the fix is a safe revert to affecting only GOOS=js files.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases arch-wasm WebAssembly issues OS-JS and removed CherryPickCandidate Used during the release process for point releases labels Aug 31, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/524855 mentions this issue: [release-branch.go1.21] net/http: revert "support streaming POST content in wasm"

gopherbot pushed a commit that referenced this issue Aug 31, 2023
@haruyama480 @gopherbot
[release-branch.go1.21] net/http: revert "support streaming POST cont…
e3ba569 
…ent in wasm"

CL 458395 added support for streaming POST content in Wasm.
Unfortunately, this breaks requests to servers that only support HTTP/1.1.
Revert the change until a suitable fallback or opt-in strategy can be decided.

For #61889.
Fixes #62328.

Change-Id: If53a77e1890132063b39abde867d34515d4ac2af
Reviewed-on: https://go-review.googlesource.com/c/go/+/522955
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/524855
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Commit-Queue: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Author

Closed by merging e3ba569 to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues CherryPickApproved Used during the release process for point releases OS-JS
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot