Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: toggle code editor off #62327

Open
Deleplace opened this issue Aug 28, 2023 · 2 comments
Open

x/website/tour: toggle code editor off #62327

Deleplace opened this issue Aug 28, 2023 · 2 comments
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. website
Milestone
website/unplanned

Comments

@Deleplace
Copy link
Contributor

Per #1437 and #62323, the Go Tour code box is not accessible to developers who are blind or visually impaired.

A useful mitigation would be to let the user choose to use the Tour in "read-only" mode:

  • lesson text contents unchanged
  • remove code editor
  • replace it with a plain text listing
    • screen reader friendly
  • keep the [Run] button
  • remove the [Reset], [Format] buttons

This choice would persist in the user browser, like other existing settings.
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2023
@Deleplace
Copy link
Contributor Author

As #62325 (link to the Playground) is most useful when we don't want to use the Tour's built-in editor, it may make sense to provide the link only in the new "read-only" mode.

Pros:

  • no visual overhead in default mode
  • less distraction/cognitive burden in default mode ("why do I have both a Run button and a Playground link? which one am I expected to use?)

Cons:

  • Playground integration less discoverable

@Deleplace
Copy link
Contributor Author

The need for a toggling away the editor would become somewhat obsolete if/when #1437 is resolved with a proper accessible code editor.

@joedian joedian added website NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Aug 28, 2023
@hyangah hyangah modified the milestones: Unreleased, website/unplanned Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. website
Projects
None yet
Milestone
website/unplanned
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @Deleplace @joedian