Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: transparent gopher image is too dark in dark theme #62316

Closed
Deleplace opened this issue Aug 28, 2023 · 3 comments
Closed

x/website/tour: transparent gopher image is too dark in dark theme #62316

Deleplace opened this issue Aug 28, 2023 · 3 comments
Milestone
Unreleased

Comments

@Deleplace
Copy link
Contributor

Deleplace commented Aug 28, 2023 •
edited

At https://go.dev/tour

The asset is a transparent PNG, it looks nice in light theme but not so much in dark.

image

image

I suggest we keep the image transparent but fill the gopher with plain white color.
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2023
@gopherbot
Copy link

Change https://go.dev/cl/523415 mentions this issue: _content: apply white color in transparent gopher, for dark theme.

@Deleplace
Copy link
Contributor Author

After fix suggested in CL 523415:

image

Dark theme

image

Light theme

image

@Deleplace
Copy link
Contributor Author

cc @jamalc

willpoint pushed a commit to orijtech/website that referenced this issue Oct 17, 2023
@Deleplace @willpoint
_content: apply white color in transparent gopher, for dark theme.
9530496 
Fixes golang/go#62316

Change-Id: I5bda00629a5de3e3266911c0c518b6c2078e4b97
Reviewed-on: https://go-review.googlesource.com/c/website/+/523415
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Auto-Submit: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @Deleplace