Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: use system setting prefers-color-scheme #62314

Open
Deleplace opened this issue Aug 28, 2023 · 2 comments
Open

x/website/tour: use system setting prefers-color-scheme #62314

Deleplace opened this issue Aug 28, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
website/unplanned

Comments

@Deleplace
Copy link
Contributor

Deleplace commented Aug 28, 2023 •
edited

Since 509116, the Tour has a dark mode, which is awesome.

However, it shows up in light mode by default, even if my OS/browser settings say I prefer dark.

The rest of the website has had the same problem at first, and it has been fixed. The user may click a top-right icon to toggle the light/dark theme, and this explicitl user choice is persisted. However, the default theme (without any user action) should acknowledge the system-wide preference.

image
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2023
@Deleplace
Copy link
Contributor Author

cc @jamalc

@joedian joedian added website NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 28, 2023
@hyangah hyangah modified the milestones: Unreleased, website/unplanned Aug 31, 2023
@hyangah
Copy link
Contributor

hyangah commented Aug 31, 2023

Indeed this is confusing. x/tour is a separate codebase, so not handled in the recent accessibility improvement work. Moved to the unplanned milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
website/unplanned
Development

No branches or pull requests
4 participants
@hyangah @gopherbot @Deleplace @joedian