Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: "not marked addrtaken" ICE since CL 522879 #62313

Closed
mdempsky opened this issue Aug 28, 2023 · 1 comment
Closed

cmd/compile: "not marked addrtaken" ICE since CL 522879 #62313

mdempsky opened this issue Aug 28, 2023 · 1 comment
Assignees
@mdempsky
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.22

Comments

@mdempsky
Copy link
Member

https://go.dev/play/p/MJ6BinCcAOv?v=gotip is ICE'ing since CL 522879.

The issue is I just forgot to mark Addrtaken on the Canonical ONAME. (This was done in ComputeAddrtaken, but not in markAddrOf; I missed the difference, and it happens that only ComputeAddrtaken ever visited non-canonical ONAMEs.)
@mdempsky mdempsky added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Aug 28, 2023
@mdempsky mdempsky added this to the Go1.22 milestone Aug 28, 2023
@mdempsky mdempsky self-assigned this Aug 28, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 28, 2023
@gopherbot
Copy link

Change https://go.dev/cl/523375 mentions this issue: cmd/compile/internal/ir: set Addrtaken on Canonical ONAME too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdempsky mdempsky

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot