Not sure whether this should be a "proposal" or "bug"... 😅

I might not be hitting my "if len(attr.Value.Group() == 0" code path because Record.Add already ignores the empty group in the key/value pairs. As with PC special cases, a direct call to the handler's Handle will be needed to cover this case.

There is no new API here so this doesn't have to be a proposal. Thanks.

slogtest deliberately uses only one or two value kinds so users don't have to write full parsers. I don't want to change that. Same applies to custom types.

I don't know what the test would be for error levels. We already check for the presence of the level key. Anything else would be format-dependent.

empty group in a key/value pair (WithGroup is covered)
a Record with empty PC
a Record with an unknown PC (i.e. one where runtime.CallersFrames returns nothing)

These might be worth it. I'll give it some thought. (Getting back from vacation.)

is this a good first issue to work on? im pretty new here and would like to contribute :)

empty group in a key/value pair (WithGroup is covered)

This test case covers that:

l.Info("msg", "a", "b", slog.Group("G"), "e", "f")

@pohly did you have something else in mind?

a Record with an unknown PC (i.e. one where runtime.CallersFrames returns nothing)

I don't know a guaranteed way to generate a bad PC.

a Record with empty PC

This seems do-able: verify that a handler doesn't output an attribute whose key is slog.SourceKey if Record.PC is zero.

@AthulMuralidhar This would be a good beginner project. I believe it is relatively straightforward to add this case to slogtest.go.

l.Info("msg", "a", "b", slog.Group("G"), "e", "f")
@pohly did you have something else in mind?

That's it, but I suspect it must be passed to slog.Handler.Handle, not slog.Logger. Otherwise the handler will not see it.

@jba thx! i'll setup and start getting busy :) - started on a fork here: AthulMuralidhar#1

Change https://go.dev/cl/536117 mentions this issue: testing/slogtest: test no source key with empty PC in record

@ianlancetaylor @jba

Could you please re-open this?
Some test cases are still not covered.

Change https://go.dev/cl/562635 mentions this issue: testing/slogtest: test nested groups in empty record