Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/config: temporarily allow gopls devel versions to upload telemetry data #62271

Open
hyangah opened this issue Aug 24, 2023 · 5 comments
Open

x/telemetry/config: temporarily allow gopls devel versions to upload telemetry data #62271

hyangah opened this issue Aug 24, 2023 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 24, 2023

Gopls in the dev branch is collecting telemetry data currently, but since the upload config doesn't include counters from dev versions of gopls, the collected counters are never being uploaded. For testing, include devel version in the config during the dev cycle.

Alternative #1: we can have a separate version of config used for development and staging, and include devel there.
Alternative #2: tag gopls.

cc @golang/tools-team @jamalc
@gopherbot gopherbot added the telemetry x/telemetry issues label Aug 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 24, 2023
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 25, 2023
@gopherbot
Copy link

Change https://go.dev/cl/523699 mentions this issue: config: temporarily add gopls@devel to allowed program versions

gopherbot pushed a commit to golang/telemetry that referenced this issue Aug 29, 2023
@hyangah @gopherbot
config: temporarily add gopls@devel to allowed program versions
7e37533 
And increase the default rate from 0.1 to 1.0.
Since the telemetry is opt-in and we are still under development,
we need a higher sampling rate.

For golang/go#62271

Change-Id: I907f9a143878ab20238dd5b1ce71fde4afc24df7
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/523699
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link

Change https://go.dev/cl/534476 mentions this issue: config: temporarily allow 'devel' go version

gopherbot pushed a commit to golang/telemetry that referenced this issue Oct 11, 2023
@hyangah
config: temporarily allow 'devel' go version
29ff18e 
Many Go team members testing telemetry use gopls built with the go
built from tip.

Updates golang/go#62271

Change-Id: I892b052a599a6f72911c56ddd534572c6086dab7
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/534476
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/534855 mentions this issue: config: temporarily allow 'devel' go version

gopherbot pushed a commit to golang/telemetry that referenced this issue Oct 12, 2023
@hyangah @gopherbot
config: temporarily allow 'devel' go version
8995ee8 
Many Go team members testing telemetry use gopls built with the go
built from tip.

Attempted to add 'devel' to config in cl/534476 but it turned out
we also need to update configgen.

Updates golang/go#62271

Change-Id: I3217ce491eb676436ef61a9be9413d87c2815467
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/534855
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
@findleyr
Copy link
Contributor

findleyr commented Nov 6, 2023

This is done. Let's use this issue to track reverting this change now that the gopls prerelease is out. Blocked by #63619

@findleyr
Copy link
Contributor

We also need to make this change (temporarily) for toolchain programs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cagedmantis @hyangah @gopherbot @findleyr