Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: collect go versions used in views #62248

Closed
hyangah opened this issue Aug 23, 2023 · 1 comment
Closed

x/tools/gopls: collect go versions used in views #62248

hyangah opened this issue Aug 23, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Telemetry-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 23, 2023

  • Counter: gopls/goversion:{1.16,1.17,1.18,1.19,1.20,1.21,1.22,1.23,1.24,1.25,1.26,1.27,1.28,1.29,1.30}
  • Title: Go versions in use for gopls views
  • Description: measure go version usage distribution.
  • Type: partition
  • Issue: https://go.dev/issue/62248
  • Program: golang.org/x/tools/gopls
  • Version: v0.13.0

Why?

This answers what Go versions users use to build their projects, which naturally helps us
decide on gopls, vscode-go's Go version support window.
Note that this is independent of the go version used to build gopls.
For example, it is possible to build a gopls with go1.21.x and use it to work with a project
that targets go1.20.x

Does it carry sensitive user information?

No.
This reports only the minor version of the Go. It does not distinguish modified versions of Go.

How?

https://github.com/golang/tools/blob/master/gopls/internal/telemetry/telemetry.go#L74-L80

note: The default is 'local' which does not send any data to the telemetry server. Users must opt-in explicitly.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 23, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 23, 2023
@hyangah hyangah modified the milestones: Unreleased, gopls/backlog Aug 29, 2023
@gopherbot
Copy link

Change https://go.dev/cl/528295 mentions this issue: internal/configgen: add approved new gopls counters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Telemetry-Accepted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Development

No branches or pull requests

3 participants