New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: README relative image links are broken if hosted on googlesource.com #62226

Open

maruel opened this issue Aug 22, 2023 · 1 comment

Labels

pkgsite

Milestone

pkgsite/backlog

Contributor

maruel commented Aug 22, 2023

Similar to issue #37194 but when the source code resolves to *.googlesource.com.

Repro:

Host a project on googlesource.com
Create a redirector, e.g. go.fuchsia.dev/shac-project/shac -> https://fuchsia.googlesource.com/shac-project/shac
Include a relative image in the README.md, e.g. ![usage demonstration](images/demo.gif)

Example:

The latter has a broken image.

The text was updated successfully, but these errors were encountered:

gopherbot added the pkgsite label

gopherbot added this to the Unreleased milestone

Contributor

findleyr commented Aug 24, 2023

Thanks for the report. I believe there's some hard-coded linking behavior for certain hosts, and we should add googlesource.com.

findleyr modified the milestones: Unreleased, pkgsite/backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment