Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose failures #62224

Closed
gopherbot opened this issue Aug 22, 2023 · 16 comments
Closed

net/http: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose failures #62224

gopherbot opened this issue Aug 22, 2023 · 16 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@gopherbot
Copy link

gopherbot commented Aug 22, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && (test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose" || `FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose`)

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.52s)
        transport_test.go:6824: Backend address: 127.0.0.1:60372
        transport_test.go:6842: Proxy address: 127.0.0.1:45437
        transport_test.go:6838: Expected proxy copy error

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 22, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-22 22:22 android-386-emu go@291a32aa net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.52s)
        transport_test.go:6824: Backend address: 127.0.0.1:60372
        transport_test.go:6842: Proxy address: 127.0.0.1:45437
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:22 linux-amd64-newinliner go@291a32aa net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:41111
        transport_test.go:6842: Proxy address: 127.0.0.1:40813
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-22 22:52 android-amd64-emu go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.52s)
        transport_test.go:6824: Backend address: 127.0.0.1:40204
        transport_test.go:6842: Proxy address: 127.0.0.1:48396
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:52 linux-arm-aws go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:44417
        transport_test.go:6842: Proxy address: 127.0.0.1:43561
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:52 linux-ppc64-sid-buildlet go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:36063
        transport_test.go:6842: Proxy address: 127.0.0.1:32823
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-22 22:22 linux-amd64-bookworm go@291a32aa net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:38575
        transport_test.go:6842: Proxy address: 127.0.0.1:43457
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:22 linux-ppc64le-power9osu go@291a32aa net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:41771
        transport_test.go:6842: Proxy address: 127.0.0.1:42941
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:52 linux-amd64-bookworm go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:33605
        transport_test.go:6842: Proxy address: 127.0.0.1:40521
        transport_test.go:6838: Expected proxy copy error
2023-08-22 22:52 linux-ppc64le-power9osu go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:45863
        transport_test.go:6842: Proxy address: 127.0.0.1:35333
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 linux-amd64-bookworm go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:40293
        transport_test.go:6842: Proxy address: 127.0.0.1:44051
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 linux-ppc64le-power10osu go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:36337
        transport_test.go:6842: Proxy address: 127.0.0.1:41291
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 00:16 darwin-amd64-11_0 go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.69s)
        transport_test.go:6824: Backend address: 127.0.0.1:51596
        transport_test.go:6842: Proxy address: 127.0.0.1:51599
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 darwin-amd64-12_0 go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.69s)
        transport_test.go:6824: Backend address: 127.0.0.1:52036
        transport_test.go:6842: Proxy address: 127.0.0.1:52042
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 linux-ppc64le-buildlet go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:45009
        transport_test.go:6842: Proxy address: 127.0.0.1:33097
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 00:30 linux-amd64-clang go@47112996 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:45369
        transport_test.go:6842: Proxy address: 127.0.0.1:37775
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-386-sid go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:35745
        transport_test.go:6842: Proxy address: 127.0.0.1:43603
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-amd64-bullseye go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:34749
        transport_test.go:6842: Proxy address: 127.0.0.1:38597
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-amd64-buster go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:41639
        transport_test.go:6842: Proxy address: 127.0.0.1:45803
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-ppc64-sid-buildlet go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.54s)
        transport_test.go:6824: Backend address: 127.0.0.1:45155
        transport_test.go:6842: Proxy address: 127.0.0.1:42669
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 00:30 linux-ppc64le-power9osu go@47112996 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:34685
        transport_test.go:6842: Proxy address: 127.0.0.1:45865
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-ppc64le-power9osu go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:40269
        transport_test.go:6842: Proxy address: 127.0.0.1:40193
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:14 android-amd64-emu go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.53s)
        transport_test.go:6824: Backend address: 127.0.0.1:45469
        transport_test.go:6842: Proxy address: 127.0.0.1:58249
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-386-buster go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:42461
        transport_test.go:6842: Proxy address: 127.0.0.1:43951
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 linux-amd64-alpine go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:44977
        transport_test.go:6842: Proxy address: 127.0.0.1:37633
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:14 darwin-amd64-13 go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.58s)
        transport_test.go:6824: Backend address: 127.0.0.1:51704
        transport_test.go:6842: Proxy address: 127.0.0.1:51705
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 darwin-amd64-12_0 go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.77s)
        transport_test.go:6824: Backend address: 127.0.0.1:52592
        transport_test.go:6842: Proxy address: 127.0.0.1:52595
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:14 darwin-amd64-13 go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.56s)
        transport_test.go:6824: Backend address: 127.0.0.1:51636
        transport_test.go:6842: Proxy address: 127.0.0.1:51637
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:14 windows-arm64-11 go@7f92dcc8 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.52s)
        transport_test.go:6824: Backend address: 127.0.0.1:65166
        transport_test.go:6842: Proxy address: 127.0.0.1:65167
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:14 darwin-amd64-longtest go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.54s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.54s)
        transport_test.go:6824: Backend address: 127.0.0.1:65164
        transport_test.go:6842: Proxy address: 127.0.0.1:65165
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@bcmills bcmills mentioned this issue Aug 23, 2023
Closed
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Aug 23, 2023
@bcmills bcmills added this to the Go1.22 milestone Aug 23, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/522097 mentions this issue: net/http: revert fix request canceler leak on connection close

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-22 22:52 linux-amd64-wsl go@0163b3b3 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:41701
        transport_test.go:6842: Proxy address: 127.0.0.1:40795
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 linux-amd64-wsl go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:41543
        transport_test.go:6842: Proxy address: 127.0.0.1:42665
        transport_test.go:6838: Expected proxy copy error
2023-08-23 00:16 linux-loong64-3a5000 go@556e9c5f net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:36199
        transport_test.go:6842: Proxy address: 127.0.0.1:41119
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:58 android-386-emu go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.55s)
        transport_test.go:6824: Backend address: 127.0.0.1:39890
        transport_test.go:6842: Proxy address: 127.0.0.1:42551
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:58 linux-amd64-bookworm go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:46635
        transport_test.go:6842: Proxy address: 127.0.0.1:36165
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:58 linux-arm64-boringcrypto go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:43937
        transport_test.go:6842: Proxy address: 127.0.0.1:33559
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:14 linux-ppc64le-power10osu go@70a8a41e net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:40103
        transport_test.go:6842: Proxy address: 127.0.0.1:45235
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:58 linux-amd64-race go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.59s)
        transport_test.go:6824: Backend address: 127.0.0.1:44331
        transport_test.go:6842: Proxy address: 127.0.0.1:38753
        transport_test.go:6838: Expected proxy copy error
2023-08-23 05:58 linux-ppc64le-power10osu go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:43773
        transport_test.go:6842: Proxy address: 127.0.0.1:36735
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-amd64-alpine go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:39361
        transport_test.go:6842: Proxy address: 127.0.0.1:41699
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-amd64-noopt go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:35011
        transport_test.go:6842: Proxy address: 127.0.0.1:45125
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-arm-aws go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:41787
        transport_test.go:6842: Proxy address: 127.0.0.1:35631
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-ppc64-sid-power10 go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:43037
        transport_test.go:6842: Proxy address: 127.0.0.1:40817
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose"
2023-08-23 05:58 linux-ppc64le-power9osu go@e68c0272 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:35209
        transport_test.go:6842: Proxy address: 127.0.0.1:38711
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-ppc64le-buildlet go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.51s)
        transport_test.go:6824: Backend address: 127.0.0.1:41045
        transport_test.go:6842: Proxy address: 127.0.0.1:35833
        transport_test.go:6838: Expected proxy copy error
2023-08-23 15:49 linux-ppc64le-power9osu go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.00s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.50s)
        transport_test.go:6824: Backend address: 127.0.0.1:37265
        transport_test.go:6842: Proxy address: 127.0.0.1:45811
        transport_test.go:6838: Expected proxy copy error

— watchflakes

@bcmills bcmills mentioned this issue Aug 23, 2023
Closed
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && (test == "TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose" || `FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose`)
2023-08-23 15:49 darwin-amd64-longtest go@081d27a2 net/http.TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (log) 
--- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose (0.53s)
    --- FAIL: TestTransportAndServerSharedBodyReqCancelerCleanupOnConnectionClose/h1 (0.53s)
        transport_test.go:6824: Backend address: 127.0.0.1:64201
        transport_test.go:6842: Proxy address: 127.0.0.1:64202
        transport_test.go:6838: Expected proxy copy error

— watchflakes

cellularmitosis pushed a commit to cellularmitosis/go that referenced this issue Aug 24, 2023
@AlexanderYastrebov @cellularmitosis
net/http: revert fix request canceler leak on connection close
8cb5491 
This reverts CL 515796 due to a flaking test.

Updates golang#61708
Fixes golang#62224

Change-Id: I53911a07677d08c3196daaaa2708269593baf472
GitHub-Last-Rev: 3544648
GitHub-Pull-Request: golang#62233
Reviewed-on: https://go-review.googlesource.com/c/go/+/522097
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.22
Development

Successfully merging a pull request may close this issue.

net/http: revert fix request canceler leak on connection close AlexanderYastrebov/go
2 participants
@bcmills @gopherbot