Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add vscode-insiders bucket to the gopls/client counter #62214

Closed
findleyr opened this issue Aug 22, 2023 · 1 comment
Closed

x/tools/gopls: add vscode-insiders bucket to the gopls/client counter #62214

findleyr opened this issue Aug 22, 2023 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Telemetry-Accepted Telemetry-Proposal Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 22, 2023 •
edited

As an extension of #61038, @pjweinb proposes in #61038 (comment) to add a vscode-insiders bucket to the gopls/client counter. New definition:

  • Counter: gopls/client:{vscode,vscode-insiders,vscodium,code-server,eglot,govim,neovim,coc.nvim,sublimetext,other}
  • Title: Editor Distribution
  • Description: measure editor distribution for gopls users.
  • Type: partition
  • Issue: go.dev/issues/61038
  • Issue: go.dev/issues/62214
  • Program: golang.org/x/tools/gopls

Why?

We believe we have a significant number of users on this client, and sometimes new LSP features are available in VS Code Insiders that aren't yet available in VS Code.

Does it carry sensitive user information?

No.

How?

Same as #61038.

CC @golang/tools-team
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 22, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 22, 2023
@findleyr findleyr modified the milestones: Unreleased, gopls/later Aug 22, 2023
@hyangah hyangah mentioned this issue Aug 23, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/524204 mentions this issue: config: add vscode-insiders bucket for the gopls/client counter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Telemetry-Accepted Telemetry-Proposal Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Telemetry Proposals
Status: Done
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @findleyr