Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Service Unavailable #62210

Closed
sinux-l5d opened this issue Aug 22, 2023 · 3 comments
Closed

x/pkgsite: Service Unavailable #62210

sinux-l5d opened this issue Aug 22, 2023 · 3 comments
Labels
pkgsite
Milestone
Unreleased

Comments

@sinux-l5d
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

Screenshot

image
and
image

What did you do?

Just access the documentation

What did you expect to see?

The documentation website

What did you see instead?

Service Unavailable, title 500 Server Error
@gopherbot gopherbot added this to the Unreleased milestone Aug 22, 2023
@sinux-l5d
Copy link
Author

Closing as it's back, after 5 min downtime.

@findleyr
Copy link
Contributor

Yes, this was a bad rollout. We were paged, and rolled back. Should be fixed now.

Thanks very much for the prompt issue!

@gopherbot
Copy link

Change https://go.dev/cl/521835 mentions this issue: cmd/frontend: fix variable shadowing of redisClient

gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 22, 2023
@findleyr
cmd/frontend: fix variable shadowing of redisClient
ee7bd8d 
Following CL 514518, the redisClient is always nil, due to a variable
shadowing bug. This led to a production outage (golang/go#62210), which
was not caught because the staging environment (where push tests run)
was not configured to enforce quota.

For starters, fix the variable shadowing bug. I looked into adding a
failing test, but it seemed intractible without a major refactoring.

Change-Id: I0492b2ece49759ebcae397c6600080fc44658f2b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521835
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @sinux-l5d @findleyr