Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maps: segfault in Clone [1.21 backport] #62204

Closed
gopherbot opened this issue Aug 22, 2023 · 3 comments
Closed

maps: segfault in Clone [1.21 backport] #62204

gopherbot opened this issue Aug 22, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #62203 to be considered for backport to the next 1.21 minor release.

@gopherbot Please open a backport to 1.21.

This use of maps.Clone panics in the 1.21 release, which should never happen. We don't have to worry about earlier releases because they don't implement maps.Clone.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 22, 2023
@gopherbot gopherbot mentioned this issue Aug 22, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 22, 2023
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 23, 2023
@cagedmantis
Copy link
Contributor

Approved because it is a serious issue without a workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 23, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/522936 mentions this issue: [release-branch.go1.21] runtime: fix maps.Clone bug when cloning a map mid-grow

@gopherbot
Copy link
Author

Closed by merging 13339c7 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 25, 2023
@randall77 @cagedmantis
[release-branch.go1.21] runtime: fix maps.Clone bug when cloning a ma…
13339c7 
…p mid-grow

Fixes #62204

Change-Id: I0459d3f481b0cd20102f6d9fd3ea84335a7739a8
Reviewed-on: https://go-review.googlesource.com/c/go/+/522317
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit b303fb4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/522936
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot