Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/doc: SIGSEGV in TestGenerated #62195

Closed
gopherbot opened this issue Aug 21, 2023 · 4 comments
Closed

x/tools/gopls/doc: SIGSEGV in TestGenerated #62195

gopherbot opened this issue Aug 21, 2023 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Aug 21, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated" && `signal: segmentation fault` && date < "2023-08-22"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestGenerated (97.06s)
    generate_test.go:23: signal: segmentation fault (core dumped)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 21, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated"
2023-07-10 17:03 netbsd-arm-bsiegert tools@538a6e9e go@5fa6923b x/tools/gopls/doc.TestGenerated (log) 
--- FAIL: TestGenerated (97.06s)
    generate_test.go:23: signal: segmentation fault (core dumped)

— watchflakes

@bcmills bcmills changed the title x/tools/gopls/doc: TestGenerated failures x/tools/gopls/doc: SIGSEGV in TestGenerated Aug 21, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 21, 2023

I only see one exec.Command that could have produced this failure:
https://cs.opensource.google/go/x/tools/+/master:gopls/doc/generate.go;l=88;drc=c35476fcce7a5770bccd3bfba506393dbcfe679f

Probably this is a runtime/compiler bug, but without the stderr output from the command it's hard to be sure. 🤔

@gopherbot
Copy link
Author

Change https://go.dev/cl/521124 mentions this issue: gopls/doc: include stderr output from 'go list' in pkgDir errors

gopherbot pushed a commit to golang/tools that referenced this issue Aug 21, 2023
@gopherbot
gopls/doc: include stderr output from 'go list' in pkgDir errors
6eca6df 
For golang/go#62195.

Change-Id: I2be66e7f951cf1b0b800e4aa1423dc4989b7d27a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/521124
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
@bcmills
Copy link
Contributor

bcmills commented Aug 21, 2023

stderr logging has been added.

I expect that the failure mode that it reveals may match some existing issue, or else it is likely be a runtime/compiler bug, so I'm going to close out this issue, add a date constraint, and let watchflakes file any further failures elsewhere.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot