Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/passes/nilness: wrong internal code comment // "x is nil, y is unknown" #62160

Open
CptGit opened this issue Aug 19, 2023 · 4 comments
Open

x/tools/go/analysis/passes/nilness: wrong internal code comment // "x is nil, y is unknown" #62160

CptGit opened this issue Aug 19, 2023 · 4 comments
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@CptGit
Copy link

CptGit commented Aug 19, 2023

What version of Go are you using (go version)?

$ go version
go1.21.0 darwin/amd64

Does this issue reproduce with the latest release?

Yes

"x is nil, y is unknown" -> "y is nil, x is unknown"at https://cs.opensource.google/go/x/tools/+/refs/tags/v0.12.0:go/analysis/passes/nilness/nilness.go;l=164
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 19, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2023
@dmitshur dmitshur added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Aug 19, 2023
@dmitshur dmitshur changed the title x/tools/go/analysis/passes/nilness: minor: wrong code comment // "x is nil, y is unknown" x/tools/go/analysis/passes/nilness: wrong internal code comment // "x is nil, y is unknown" Aug 19, 2023
@dmitshur dmitshur added the Suggested Issues that may be good for new contributors looking for work to do. label Aug 19, 2023
@siddharth-sable
Copy link

siddharth-sable commented Aug 20, 2023 •
edited

Hello @dmitshur, I would love to work on this. thank you

@dmitshur
Copy link
Contributor

Thanks Siddharth, please feel free to mail a code change. See https://go.dev/doc/contribute for more information on the process.

@gopherbot
Copy link

Change https://go.dev/cl/521355 mentions this issue: nillness: updated wrong internal code comment

@siddharth-sable
Copy link

Hello, @dmitshur, I mailed a code change. Please check. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @CptGit @siddharth-sable