Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash/crc32: panic on arm64 with go1.21.0 when indexing slice [1.21 backport] #62143

Closed
gopherbot opened this issue Aug 18, 2023 · 3 comments
Closed

hash/crc32: panic on arm64 with go1.21.0 when indexing slice [1.21 backport] #62143

gopherbot opened this issue Aug 18, 2023 · 3 comments
Assignees
@randall77
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@randall77 requested issue #62131 to be considered for backport to the next 1.21 minor release.

@gopherbot please open a backport to 1.21.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 18, 2023
@gopherbot gopherbot mentioned this issue Aug 18, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 18, 2023
@randall77 randall77 self-assigned this Aug 18, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/520976 mentions this issue: [release-branch.go1.21] Revert "cmd/compile: omit redundant sign/unsign extension on arm64"

@dmitshur dmitshur changed the title hash/crc32: Panic on ARM with go1.21 when indexing slice [1.21 backport] hash/crc32: panic on arm64 with go1.21.0 when indexing slice [1.21 backport] Aug 19, 2023
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 23, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 23, 2023
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a workaround.

@gopherbot
Copy link
Author

Closed by merging cb6ea94 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 23, 2023
@randall77 @cagedmantis
[release-branch.go1.21] Revert "cmd/compile: omit redundant sign/unsi…
cb6ea94 
…gn extension on arm64"

This reverts CL 427454.

Reason for revert: causes incorrect generated code in some rare cases

We'll fix-forward at tip, so the revert just needs to be done for 1.21.

Fixes #62143

Change-Id: Id242230481ff4d4ba5f58236c6d8237729fc3b80
Reviewed-on: https://go-review.googlesource.com/c/go/+/520976
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Ruinan Sun <Ruinan.Sun@arm.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
awly pushed a commit to tailscale/go that referenced this issue Feb 7, 2024
@randall77 @awly
[release-branch.go1.21] Revert "cmd/compile: omit redundant sign/unsi…
2772552 
…gn extension on arm64"

This reverts CL 427454.

Reason for revert: causes incorrect generated code in some rare cases

We'll fix-forward at tip, so the revert just needs to be done for 1.21.

Fixes golang#62143

Change-Id: Id242230481ff4d4ba5f58236c6d8237729fc3b80
Reviewed-on: https://go-review.googlesource.com/c/go/+/520976
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Ruinan Sun <Ruinan.Sun@arm.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
JanDeDobbeleer pushed a commit to JanDeDobbeleer/go that referenced this issue Feb 12, 2024
@randall77 @JanDeDobbeleer
[release-branch.go1.21] Revert "cmd/compile: omit redundant sign/unsi…
e225daa 
…gn extension on arm64"

This reverts CL 427454.

Reason for revert: causes incorrect generated code in some rare cases

We'll fix-forward at tip, so the revert just needs to be done for 1.21.

Fixes golang#62143

Change-Id: Id242230481ff4d4ba5f58236c6d8237729fc3b80
Reviewed-on: https://go-review.googlesource.com/c/go/+/520976
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Ruinan Sun <Ruinan.Sun@arm.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randall77 randall77

Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
3 participants
@cagedmantis @randall77 @gopherbot