Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: slice bounds out of range [1.21 backport] #62140

Closed
gopherbot opened this issue Aug 18, 2023 · 3 comments
Closed

cmd/link: slice bounds out of range [1.21 backport] #62140

gopherbot opened this issue Aug 18, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@cherrymui requested issue #62098 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport this to Go 1.21. It is a regression in 1.21 causing valid programs fail to build. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 18, 2023
@gopherbot gopherbot mentioned this issue Aug 18, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 18, 2023
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 18, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/520857 mentions this issue: [release-branch.go1.21] cmd/link: don't mangle string symbol names

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 23, 2023
@cagedmantis
Copy link
Contributor

Approved as this is a regression without a workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 23, 2023
gopherbot pushed a commit that referenced this issue Aug 23, 2023
@cherrymui
[release-branch.go1.21] cmd/link: don't mangle string symbol names
bac083a 
String symbol names could contain weird characters as we put the
string literal into the symbol name. So it may appear to need
mangling. However, as string symbols are grouped into a single
"go:string.*" symbol, the individual symbol names actually don't
matter. So don't mangle them.

Also make the mangling code more defensive in case of weird
symbol names.

Updates #62098.
Fixes #62140.

Change-Id: I533012567a9fffab69debda934f426421c7abb04
Reviewed-on: https://go-review.googlesource.com/c/go/+/520856
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit b65e34f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/520857
@gopherbot
Copy link
Author

Closed by merging bac083a to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot