New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/net/html: add Node.All() iterator #62113

Open

earthboundkid opened this issue Aug 17, 2023 · 1 comment

Labels

Milestone

Contributor

earthboundkid commented Aug 17, 2023 •

edited

This is assuming #61405 is accepted.

Iterating through all the children of an html.Node is tedious. The current code has this example of a recursive function printing out links:

var f func(*html.Node)
f = func(n *html.Node) {
	if n.Type == html.ElementNode && n.Data == "a" {
		for _, a := range n.Attr {
			if a.Key == "href" {
				fmt.Println(a.Val)
				break
			}
		}
	}
	for c := n.FirstChild; c != nil; c = c.NextSibling {
		f(c)
	}
}
f(doc)

It would be much nicer with an iterator:

for n := range doc.All() {
	if n.Type == html.ElementNode && n.Data == "a" {
		for _, a := range n.Attr {
			if a.Key == "href" {
				fmt.Println(a.Val)
				break
			}
		}
	}
}

earthboundkid added the Proposal label

gopherbot added this to the Proposal milestone

Contributor

ianlancetaylor commented Aug 17, 2023

tebeka mentioned this issue

proposal: x/net/html: add Node.FindAll #62219

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment