Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/getgo: Fails with 400 Bad Request error #62112

Closed
cannona opened this issue Aug 17, 2023 · 11 comments
Closed

x/tools/cmd/getgo: Fails with 400 Bad Request error #62112

cannona opened this issue Aug 17, 2023 · 11 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@cannona
Copy link
Contributor

cannona commented Aug 17, 2023

What version of Go are you using (go version)?

$ go version
1.20.6 linux/amd64

Does this issue reproduce with the latest release?

When fetching with curl -LO https://get.golang.org/$(uname)/go_installer yes.

What operating system and processor architecture are you using (go env)?

Debion Linux on an AMD Ryzen processor.

What did you do?

curl -LO https://get.golang.org/$(uname)/go_installer && chmod +x go_installer && ./go_installer && rm go_installer

What did you expect to see?

A correct installation.

What did you see instead?

Welcome to the Go installer!
Downloading Go version go1.21.0
time 2023-08-04T20:14:06Z to /home/cannona/.go
This may take a bit of time...
Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)

Hopefully this can be fixed, or perhaps it just moves up the timeline for #60951
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 17, 2023
@dmitshur
Copy link
Contributor

Thanks for reporting this.

CC @golang/tools-team as owners of this component.

Also CC @golang/release as FYI since this is related to the user experience of Go toolchain downloads. We try to provide a good experience at https://go.dev/dl/ and via the golang.org/dl/goX.Y.Z commands, but anyone using get.golang.org misses out on that.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 17, 2023
@dmitshur
Copy link
Contributor

For what it's worth, the problem in getgo appears to be that it's treating the entire content of the VERSION file as a Go version, but as of Go 1.21.0 the VERSION file contains a timestamp on the second line. It should be using just the first line, or better yet, the go.dev/dl/?mode=json API.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 17, 2023
@wadey
Copy link
Contributor

wadey commented Aug 23, 2023

FYI, it looks like this was fixed back in 2021 with this commit, related to this issue: #42676

I'm assuming no-one has published a new build to https://get.golang.org/$(uname)/go_installer since that commit.

@giuseppe giuseppe mentioned this issue Sep 6, 2023
Closed
@mascenzi80
Copy link

is there any update on this? I'm attempting to get Podman up and running, which is a point of failure in the process.

@hyangah
Copy link
Contributor

hyangah commented Sep 6, 2023

getgo was a proof-of-concept installer, which later got replaced with golang.org/dl/* and other installers.
get.golang.org wasn't maintained for a while.

For users who depended on getgo: can you please comment in #60951 and explain what aspect of the officially supported go installation process doesn't meet your need? Thanks!

@rkgj4106
Copy link

I had same problems...while install
is there any update???got some same errors

downloading go from 400 bad request failed with http status %!s(missing)

@seankhliao seankhliao mentioned this issue Oct 4, 2023
Closed
@Gwolfgit
Copy link

Gwolfgit commented Dec 5, 2023 •
edited

Same problem on two different systems.

Local
gwolf@orion$ uname -a
Linux orion 6.1.0-13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) x86_64 GNU/Linux

gwolf@orion$ ./go_installer
Welcome to the Go installer!
Downloading Go version go1.21.5
time 2023-11-29T21:21:46Z to /home/gwolf/.go
This may take a bit of time...
Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)

This one is a container on a remote
root@egress-tornado:~# uname -a
Linux egress-tornado 5.15.0-89-generic #99-Ubuntu SMP Mon Oct 30 20:42:41 UTC 2023 x86_64 GNU/Linux

root@egress-tornado:~# ./go_installer
Welcome to the Go installer!
Downloading Go version go1.21.5
time 2023-11-29T21:21:46Z to /root/.go
This may take a bit of time...
Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)

@Gwolfgit
Copy link

Gwolfgit commented Dec 5, 2023

getgo was a proof-of-concept installer, which later got replaced with golang.org/dl/* and other installers. get.golang.org wasn't maintained for a while.

For users who depended on getgo: can you please comment in #60951 and explain what aspect of the officially supported go installation process doesn't meet your need? Thanks!

A document that uses this installer is the first result on Google when you search "Install golang" and "download golang" so golang needs to either fix it or update the page.

@adonovan
Copy link
Member

adonovan commented Dec 5, 2023

A document that uses this installer is the first result on Google when you search "Install golang" and "download golang" so golang needs to either fix it or update the page.

Just curious, which page did Google search turn up? None of the results for me included this term. But I agree that any docs we maintain should promote only accurate answers, and the tool's own documentation should make its status clear.

@jonassteinberg1

This comment was marked as duplicate.

Sign in to view
@hyangah
Copy link
Contributor

hyangah commented Feb 16, 2024

Closing - getgo is deprecated. #60951

@hyangah hyangah closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
@chinenyeokafor chinenyeokafor mentioned this issue Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
10 participants
@wadey @cannona @dmitshur @hyangah @adonovan @gopherbot @mascenzi80 @jonassteinberg1 @Gwolfgit @rkgj4106