Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: Include build id in generated pprof profiles #62091

Closed
brancz opened this issue Aug 17, 2023 · 1 comment
Closed

runtime/pprof: Include build id in generated pprof profiles #62091

brancz opened this issue Aug 17, 2023 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Proposal

Comments

@brancz
Copy link
Contributor

brancz commented Aug 17, 2023

Build IDs are used for all sorts of matching purposes for example in the debuginfod project, to associate debuginfo, executables and sources. It would be great if pprof profiles generated by the runtime included the build ID.

Looking at a pprof profile today:

$ gzip --decompress --to-stdout /Users/brancz/pprof/pprof.prometheus.samples.cpu.001.pb.gz | protoc -I/Users/brancz/src/github.com/google/pprof/proto profile.proto --decode perftools.profiles.Profile | grep -A6 "mapping {"
mapping {
  id: 1
  memory_start: 4194304
  memory_limit: 42422272
  filename: 5
  has_functions: true
}
mapping {
  id: 2
  memory_start: 140729988530176
  memory_limit: 140729988538368
  filename: 6
}
mapping {
  id: 3
  memory_start: 18446744073699065856
  memory_limit: 18446744073699069952
  filename: 7
}
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 17, 2023
@seankhliao
Copy link
Member

Duplicate of #59307

@seankhliao seankhliao marked this as a duplicate of #59307 Aug 17, 2023
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
@golang golang locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge Proposal
Projects
None yet
Development

No branches or pull requests

3 participants