Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/xml: incompatible changes in the Go 1.21.0 [1.21 backport] #62051

Closed
gopherbot opened this issue Aug 15, 2023 · 2 comments
Closed

encoding/xml: incompatible changes in the Go 1.21.0 [1.21 backport] #62051

gopherbot opened this issue Aug 15, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@bcmills requested issue #61881 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. Per #56986 this should at least have a release note and a GODEBUG guard.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 15, 2023
@gopherbot gopherbot mentioned this issue Aug 15, 2023
Closed
@bcmills bcmills added this to the Go1.21.1 milestone Aug 15, 2023
@xuri xuri mentioned this issue Aug 16, 2023
Closed
This was referenced Aug 23, 2023
Closed
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/522316 mentions this issue: [release-branch.go1.21] encoding/xml: overriding by empty namespace when no new name declaration

This was referenced Aug 28, 2023
Closed
Closed
Closed
@gopherbot
Copy link
Author

Closed by merging 2d07bb8 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 30, 2023
@xuri @gopherbot
[release-branch.go1.21] encoding/xml: overriding by empty namespace w…
2d07bb8 
…hen no new name declaration

The unmarshal and marshal XML text should be consistent if not modified deserialize variable.

For #61881
Fixes #62051

Change-Id: I475f7b05211b618685597d3ff20b97e3bbeaf8f8
GitHub-Last-Rev: 6831c77
GitHub-Pull-Request: #58401
Reviewed-on: https://go-review.googlesource.com/c/go/+/522316
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 30, 2023
@redraskal redraskal mentioned this issue Aug 30, 2023
Merged
3 tasks
This was referenced Aug 31, 2023
Closed
Closed
@StevenMaude StevenMaude mentioned this issue Sep 2, 2023
Closed
This was referenced Sep 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot