Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: crypto/x509: remove x509sha1 GODEBUG in Go 1.24 #62048

Open
rsc opened this issue Aug 15, 2023 · 2 comments
Open

proposal: crypto/x509: remove x509sha1 GODEBUG in Go 1.24 #62048

rsc opened this issue Aug 15, 2023 · 2 comments
Labels
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Aug 15, 2023

Go 1.18 disabled the use of SHA1 in most X.509 certificates by default but added a GODEBUG for re-enabling them, to accommodate private CAs that might not have updated yet. https://go.dev/crypto/x509#InsecureAlgorithmError

Per https://go.dev/doc/godebug#go-118 we can remove that GODEBUG in Go 1.22 or later. The GKE team, which is the only team that reached out about needing to keep SHA1, has gathered metrics about their own dependence (via customers) on this setting, and they believe that they won't need it anymore after Go 1.23.

Unless there are other users who need us to keep the setting around longer, I propose that we retire the x509sha1 GODEBUG in Go 1.24. We would pre-announce this in the release notes for both Go 1.22 and Go 1.23.

@gopherbot gopherbot added this to the Proposal milestone Aug 15, 2023
@liggitt
Copy link
Contributor

liggitt commented Feb 2, 2024

looks like this isn't mentioned in the tip release notes for 1.22 at https://tip.golang.org/doc/go1.22 ... should it be?

@SnowmanCharles
Copy link

Hi, just wondering was this proposal finally executed? Are we still supporting SHA1 in in Go 1.24?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

4 participants