Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: deprecate the "tempModfile" setting #61970

Closed
findleyr opened this issue Aug 12, 2023 · 2 comments
Closed

x/tools/gopls: deprecate the "tempModfile" setting #61970

findleyr opened this issue Aug 12, 2023 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@findleyr
Copy link
Contributor

This setting is not exposed in documentation, complicates the code, and can't be working correctly. Remove it.

I think it was intended to allow automatic go.mod mutation in combination with "allowModfileModification", but that is probably not working well, and significantly complicates our go command invocation.

In any case, I don't know how "tempModfile" is meant to be used, which is a sign that it should be removed...
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Aug 12, 2023
@findleyr findleyr added this to the gopls/v0.14.0 milestone Aug 12, 2023
@gopherbot
Copy link

Change https://go.dev/cl/518976 mentions this issue: gopls/internal/lsp/mod: remove TestModfileRemainsUnchanged

gopherbot pushed a commit to golang/tools that referenced this issue Aug 23, 2023
@findleyr
gopls/internal/lsp/mod: remove TestModfileRemainsUnchanged
8fd71c0 
Testdata for this test includes a go.mod file, which is problematic for
a number of reasons (e.g. running from the mod cache; go work use -r).

Replace it with a regtest. But really we should just delete the
"tempModfile" setting (golang/go#61970).

Fixes golang/go#57784

Change-Id: I79726c6106f3118d021a8f9ef52f385f1393d4a8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/518976
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
@findleyr findleyr changed the title x/tools/gopls: remove the "tempModfile" setting x/tools/gopls: deprecate the "tempModfile" setting Oct 13, 2023
@findleyr findleyr mentioned this issue Oct 13, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/534919 mentions this issue: gopls: deprecate "tempModfile" and "expandWorkspaceToModule" settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.14.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr