Skip to content

go/types, types2: panic: infinite recursion in unification with go1.21.0 [1.21 backport] #61959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 11, 2023 · 2 comments
Closed

go/types, types2: panic: infinite recursion in unification with go1.21.0 [1.21 backport] #61959

gopherbot opened this issue Aug 11, 2023 · 2 comments
Assignees
@griesemer
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.21.1

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #61879 to be considered for backport to the next 1.21 minor release.

@griesemer and I will try to fix this for Go1.21.1.

@gopherbot please backport this to 1.21. It is a new panic during type checking.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 11, 2023
@gopherbot gopherbot mentioned this issue Aug 11, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 11, 2023
@griesemer griesemer self-assigned this Aug 14, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/519416 mentions this issue: [release-branch.go1.21] go/types, types2: use exact unification when comparing interface methods

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 16, 2023
gopherbot pushed a commit that referenced this issue Aug 17, 2023
@griesemer @gopherbot
[release-branch.go1.21] go/types, types2: use exact unification when …

Verified

This commit was signed with the committer’s verified signature.
wooorm Titus
GPG key ID: E6E581152ED04E2E
Verified
Learn about vigilant mode
7437db1 
…comparing interface methods

Irrespective of whether unification is exact or inexact, method
signatures of interfaces must always match exactly: a type never
satisfies/implements an interface if relevant method signatures
are different (i.e., not identical, possibly after substitution).

Fixes #61959.

Change-Id: I20c0aa28ac86e2edec615b40f2269938e4a96938
Reviewed-on: https://go-review.googlesource.com/c/go/+/519435
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/519416
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 7437db1 to release-branch.go1.21.

@golang golang locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@griesemer griesemer

Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
3 participants
@dmitshur @griesemer @gopherbot