Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/distpack: release archives don't include directory members [1.21 backport] #61927

Closed
gopherbot opened this issue Aug 10, 2023 · 4 comments
Closed

cmd/distpack: release archives don't include directory members [1.21 backport] #61927

gopherbot opened this issue Aug 10, 2023 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases release-blocker
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@rsc requested issue #61862 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport go1.21
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 10, 2023
@gopherbot gopherbot mentioned this issue Aug 10, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 10, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/518835 mentions this issue: [release-branch.go1.21] cmd/distpack: include directory entries in tar files

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Aug 11, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 11, 2023
@heschi
Copy link
Contributor

heschi commented Aug 11, 2023

Oops, I +2'd the CL without thinking. Approved retroactively and unilaterally.

@gopherbot
Copy link
Author

Closed by merging 9398951 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 11, 2023
@rsc @gopherbot
[release-branch.go1.21] cmd/distpack: include directory entries in ta…
9398951 
…r files

Various tools expect tar files to contain entries for directories.
I dropped them when writing cmd/distpack because they're not
strictly necessary and omitting them saves space, but it also
turns out to break some things, so add them back.

We will backport this to release-branch.go1.21 so that Go 1.21.1
will include the directory entries. We can't do anything about
Go 1.21.0 retroactively.

% tar tzvf go1.22rsc1.src.tar.gz | sed 10q
drwxr-xr-x  0 0      0           0 Aug 10 10:07 go/
-rw-r--r--  0 0      0        1337 Aug 10 10:07 go/CONTRIBUTING.md
-rw-r--r--  0 0      0        1479 Aug 10 10:07 go/LICENSE
-rw-r--r--  0 0      0        1303 Aug 10 10:07 go/PATENTS
-rw-r--r--  0 0      0        1455 Aug 10 10:07 go/README.md
-rw-r--r--  0 0      0         419 Aug 10 10:07 go/SECURITY.md
-rw-r--r--  0 0      0          42 Aug 10 10:07 go/VERSION
drwxr-xr-x  0 0      0           0 Aug 10 10:07 go/api/
-rw-r--r--  0 0      0        1142 Aug 10 10:07 go/api/README
-rw-r--r--  0 0      0       35424 Aug 10 10:07 go/api/except.txt
% tar tzvf go1.22rsc1.darwin-amd64.tar.gz | sed 10q
drwxr-xr-x  0 0      0           0 Aug 10 10:07 go/
-rw-r--r--  0 0      0        1337 Aug 10 10:07 go/CONTRIBUTING.md
-rw-r--r--  0 0      0        1479 Aug 10 10:07 go/LICENSE
-rw-r--r--  0 0      0        1303 Aug 10 10:07 go/PATENTS
-rw-r--r--  0 0      0        1455 Aug 10 10:07 go/README.md
-rw-r--r--  0 0      0         419 Aug 10 10:07 go/SECURITY.md
-rw-r--r--  0 0      0          42 Aug 10 10:07 go/VERSION
drwxr-xr-x  0 0      0           0 Aug 10 10:07 go/api/
-rw-r--r--  0 0      0        1142 Aug 10 10:07 go/api/README
-rw-r--r--  0 0      0       35424 Aug 10 10:07 go/api/except.txt
%

Fixes #61862.
Fixes #61927.

Change-Id: Iecd9ba893015295e88715b031b79a104236b9ced
Reviewed-on: https://go-review.googlesource.com/c/go/+/518335
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/518835
Auto-Submit: Russ Cox <rsc@golang.org>
@dmitshur
Copy link
Contributor

Note that it's okay and helpful to review backport CLs, even before the backport issue is approved, since submission can only be done by release managers who do take the backport process into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases release-blocker
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi