Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.13.2 #61926

Closed
8 tasks done
findleyr opened this issue Aug 10, 2023 · 3 comments
Closed
8 tasks done

x/tools/gopls: release version v0.13.2 #61926

findleyr opened this issue Aug 10, 2023 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.13.2

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 10, 2023 •
edited

This issue tracks progress toward releasing gopls@v0.13.2

  • cherry-pick into gopls-release-branch.0.13
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.13.2-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.13.2
@findleyr findleyr added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Aug 10, 2023
@findleyr findleyr added this to the gopls/v0.13.2 milestone Aug 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/518216 mentions this issue: [gopls-release-branch.0.13] refactor/satisfy: (re)allow composite lits of pointer type

gopherbot pushed a commit to golang/tools that referenced this issue Aug 10, 2023
@findleyr
[gopls-release-branch.0.13] refactor/satisfy: (re)allow composite lit…
3c11934 
…s of pointer type

CL 513775 fixed a bug related to composite lits of type parameter type,
but inadvertently removed handling for lits of pointer type (the 'deref'
call was replaced, rather than wrapped).

This results in a panic for unnamed literals of pointer type (such as
in []*X{{}}).

Replace the defer.

Updates golang/go#61813
For golang/go#61926

Change-Id: I2a66f6bfebd6d6d11a5fb7bf4c1cf453bcf02d4b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/516775
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
(cherry picked from commit f42bca8)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/518216
Reviewed-by: Peter Weinberger <pjw@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/518217 mentions this issue: internal/lsp/debug: update hard-coded version for v0.13.2

gopherbot pushed a commit to golang/tools that referenced this issue Aug 10, 2023
@findleyr
internal/lsp/debug: update hard-coded version for v0.13.2
cc6b580 
For golang/go#61926

Change-Id: I84cdfb51421df7ed3a9f96b93b03be4da174e4ea
Reviewed-on: https://go-review.googlesource.com/c/tools/+/518217
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/518377 mentions this issue: gopls: update go.mod for v0.13.2-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Aug 10, 2023
@findleyr
gopls: update go.mod for v0.13.2-pre.1
2f9d82f 
Remove the replace directive and update x/tools.

For golang/go#61926

Change-Id: I80f8f58592f06aba3a91896959fc2481ca3fc563
Reviewed-on: https://go-review.googlesource.com/c/tools/+/518377
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
@findleyr findleyr modified the milestones: gopls/v0.13.2, gopls/v0.14.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.13.2
Development

No branches or pull requests
2 participants
@gopherbot @findleyr