Skip to content

runtime/internal/wasitest: TestTCPEcho is racy [1.21 backport] #61821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 7, 2023 · 4 comments
Closed

runtime/internal/wasitest: TestTCPEcho is racy [1.21 backport] #61821

gopherbot opened this issue Aug 7, 2023 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #61820 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This is a racy test, and a flaky failure was observed during the Go 1.21.0 release process.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 7, 2023
@gopherbot gopherbot mentioned this issue Aug 7, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 7, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 7, 2023
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Aug 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 9, 2023
@dmitshur
Copy link
Contributor

This is waiting on a fix for the upstream issue to be developed and reviewed.

@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 14, 2023
@chriso
Copy link
Contributor

chriso commented Aug 16, 2023

See https://go-review.googlesource.com/c/go/+/519895

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/520955 mentions this issue: [release-branch.go1.21] runtime/internal/wasitest: skip racy TCP echo test

@dmitshur dmitshur removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 18, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 70aa116 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 18, 2023
@chriso @gopherbot
[release-branch.go1.21] runtime/internal/wasitest: skip racy TCP echo…
70aa116 
… test

The wasip1 TCP echo test introduced in CL 493358 has a race
condition with port selection. The test runner probes for a free
port and then asks the WASM runtime to listen on the port, which
may be taken by another process in the interim.

Due to limitations with WASI preview 1, the guest is unable to
query the port it's listening on. The test cannot ask the WASM
runtime to listen on port 0 (choose a free port) since there's
currently no way for the test to query the selected port and
connect to it.

Given the race condition is unavoidable, this test is now disabled
by default and requires opt-in via an environment variable.

This commit also eliminates the hard-coded connection timeout.

Updates #61820.
Fixes #61821.

Change-Id: I375145c1a1d03ad45c44f528da3347397e6dcb01
Reviewed-on: https://go-review.googlesource.com/c/go/+/519895
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 795e779)
Reviewed-on: https://go-review.googlesource.com/c/go/+/520955
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
4 participants
@chriso @dmitshur @gopherbot @heschi