Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: panic: runtime error: index out of range [-1] in collectDepsErrors [1.21 backport] #61818

Closed
gopherbot opened this issue Aug 7, 2023 · 2 comments
Closed

cmd/go: panic: runtime error: index out of range [-1] in collectDepsErrors [1.21 backport] #61818

gopherbot opened this issue Aug 7, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Milestone
Go1.21.1

Comments

@gopherbot
Copy link

@findleyr requested issue #61816 to be considered for backport to the next 1.21 minor release.

@gopherbot please consider this for backport to 1.21. It is a new Go command crash.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 7, 2023
@gopherbot gopherbot mentioned this issue Aug 7, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 7, 2023
@bcmills bcmills added the GoCommand cmd/go label Aug 7, 2023
@bcmills bcmills added CherryPickApproved Used during the release process for point releases release-blocker and removed CherryPickCandidate Used during the release process for point releases labels Aug 15, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/519658 mentions this issue: [release-branch.go1.21] cmd/go: fix missing case checking for empty slice

@gopherbot
Copy link
Author

Closed by merging 3475e6a to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 15, 2023
@matloob @gopherbot
[release-branch.go1.21] cmd/go: fix missing case checking for empty s…
3475e6a 
…lice

When we were comparing the first element of import stacks when sorting
depserrors we checked if the first stack was non empty, but not the
second one. Do the check for both stacks.

Fixes #61818
Updates #61816
For #59905

Change-Id: Id5c11c2b1104eec93196a08c53372ee2ba97c701
Reviewed-on: https://go-review.googlesource.com/c/go/+/516739
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
(cherry picked from commit 58447d7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/519658
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot