Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: ProxyFromEnvironment doesn't support "https_proxy" environmental variables #6181

Closed
gopherbot opened this issue Aug 18, 2013 · 8 comments
Closed

net/http: ProxyFromEnvironment doesn't support "https_proxy" environmental variables #6181

gopherbot opened this issue Aug 18, 2013 · 8 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@gopherbot
Copy link

by mitchell.hashimoto:

The "ProxyFromEnvironment" function is great, but doesn't properly support the
"HTTPS_PROXY" variable which is also standard across many Unix tools that
perform HTTP requests. 

The best documentation I could find was this reference for GNU wget:

http://www.gnu.org/software/wget/manual/html_node/Proxies.html
@robpike
Copy link
Contributor

robpike commented Aug 19, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 9, 2013

Comment 2:

I think this will need to wait until Go 1.3.
I can't tell what HTTPS_PROXY is for.
Is it supposed to be used for all URLs, and you just connect via HTTPS?
Or is it supposed to be used only for https URLs, and if so do you connect to the proxy
via HTTP or HTTPS?

Labels changed: added go1.3maybe, removed go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-main.

@gopherbot
Copy link
Author

Comment 5 by dan@walshclan.org:

Did this make it into golang 1.3?  We have a bugzilla on docker for this.
https://bugzilla.redhat.com/show_bug.cgi?id=1106334

@ianlancetaylor
Copy link
Contributor

Comment 6:

There is no current support for HTTPS_PROXY.  There is a chance we can get it into 1.4
if it simple.  It would help if somebody could answer Russ's questions in comment #2.

Labels changed: added release-go1.4, removed priority-later, release-none.

@gopherbot
Copy link
Author

Comment 7:

CL https://golang.org/cl/148980043 mentions this issue.

@bradfitz
Copy link
Contributor

Comment 8:

This issue was closed by revision e6f21be.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@bradfitz @wheatman
net/http: support https_proxy in ProxyFromEnvironment
08b64d7 
Fixes golang#6181

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/148980043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@bradfitz @wheatman
net/http: support https_proxy in ProxyFromEnvironment
cacc5c9 
Fixes golang#6181

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/148980043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@bradfitz @wheatman
net/http: support https_proxy in ProxyFromEnvironment
b648422 
Fixes golang#6181

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/148980043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@bradfitz @wheatman
net/http: support https_proxy in ProxyFromEnvironment
3a757bd 
Fixes golang#6181

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/148980043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
5 participants
@bradfitz @rsc @ianlancetaylor @robpike @gopherbot