You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This proposal is part of a set of proposals that culminate in moving the HTTP/2 implementation into the standard library. See discussion #60746.
This specific proposal makes the HTTP/2 client and server configurations more consistent, which will simplify adding these configurations to net/http. (Also, it seems like a reasonable feature considered on its own.)
HTTP/2 transports have a Transport.WriteByteTimeout configuration setting, which sets the maximum time a single write to a connection may take. The timeout begins when a write is made, and is extended whenever any data is written.
This setting can be used to detect unresponsive connections when the timeout for an entire request may be large or unbounded.
I propose extending this feature to apply to HTTP/2 server connections.
package http2
type Server struct { // contains unchanged fields
// WriteByteTimeout is the timeout after which a connection will be
// closed if no data can be written to it. The timeout begins when data is
// available to write, and is extended whenever any bytes are written.
WriteByteTimeout time.Duration
}
I'd originally thought to propose adding WriteByteTimeout to HTTP/1 connections as well, but there's less motivation for it there: HTTP/1 connections only handle a single request at at time, and a connection can only be reused after a complete request/response cycle is completed. There's less need to separate the response write timeout from an individual byte-write timeout. In addition, it's pretty much impossible to implement a byte-write timeout when using the sendfile path.
Maybe it would make sense to add something like this for HTTP/1, but it's simpler to consider HTTP/2 for now.
The text was updated successfully, but these errors were encountered:
This proposal is part of a set of proposals that culminate in moving the HTTP/2 implementation into the standard library. See discussion #60746.
This specific proposal makes the HTTP/2 client and server configurations more consistent, which will simplify adding these configurations to
net/http
. (Also, it seems like a reasonable feature considered on its own.)HTTP/2 transports have a
Transport.WriteByteTimeout
configuration setting, which sets the maximum time a single write to a connection may take. The timeout begins when a write is made, and is extended whenever any data is written.This setting can be used to detect unresponsive connections when the timeout for an entire request may be large or unbounded.
I propose extending this feature to apply to HTTP/2 server connections.
I'd originally thought to propose adding
WriteByteTimeout
to HTTP/1 connections as well, but there's less motivation for it there: HTTP/1 connections only handle a single request at at time, and a connection can only be reused after a complete request/response cycle is completed. There's less need to separate the response write timeout from an individual byte-write timeout. In addition, it's pretty much impossible to implement a byte-write timeout when using thesendfile
path.Maybe it would make sense to add something like this for HTTP/1, but it's simpler to consider HTTP/2 for now.
The text was updated successfully, but these errors were encountered: