Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: retrieve bot list from gomote server #61773

Closed
Tracked by #61772
cagedmantis opened this issue Aug 4, 2023 · 6 comments
Closed
Tracked by #61772

x/build/cmd/gomote: retrieve bot list from gomote server #61773

cagedmantis opened this issue Aug 4, 2023 · 6 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

No description provided.

@cagedmantis cagedmantis mentioned this issue Aug 4, 2023
Closed
37 tasks
@cagedmantis cagedmantis self-assigned this Aug 4, 2023
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 4, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 4, 2023
@cagedmantis cagedmantis modified the milestones: Unreleased, Backlog Aug 4, 2023
@heschi heschi moved this to In Progress in Go Release Aug 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/518798 mentions this issue: internal/gomote: implement list swarming bots endpoint

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/518797 mentions this issue: internal/swarmclient: add LUCI config client

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/518799 mentions this issue: cmd/gomote: list swarming builders on create

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/518796 mentions this issue: internal/gomote/protos: add a list swarming builders endpoint

gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/gomote/protos: add a list swarming builders endpoint
c783e11 
This change adds a GRPC endpint to the gomote server which
lists all of the LUCI swarming builders for the project. The
builders names will be used to request the types of gomote
instance requested.

Updates golang/go#61773
For golang/go#61772

Change-Id: I2c6bfb3d251967b8008ba64ee28f2e1c8472df5b
Reviewed-on: https://go-review.googlesource.com/c/build/+/518796
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/swarmclient: add LUCI config client
a8f30e9 
This change creates a LUCI config client. This client
will be used to query the LUCI configuration service.

Updates golang/go#61773
For golang/go#61772

Change-Id: I1b23facc304e8865be9c900af5b53874840fba47
Reviewed-on: https://go-review.googlesource.com/c/build/+/518797
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/gomote: implement list swarming bots endpoint
8e06b07 
This change adds an endpoint to list the swarming builders which are
available for the gomote user to create and instance from.

Updates golang/go#61773
For golang/go#61772

Change-Id: Ic2bd0bb5d9b5866399370197fa543ea949addc31
Reviewed-on: https://go-review.googlesource.com/c/build/+/518798
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
cmd/gomote: list swarming builders on create
27b08b3 
If a create is issued without a gomote instance type, the gomote
client will query the gomote server for all available instance types.
This adds the ability to query for swarming builder types.

Updates golang/go#61773
For golang/go#61772

Change-Id: If8d9a2d6b0aa509aafd199ec140659cb7d664308
Reviewed-on: https://go-review.googlesource.com/c/build/+/518799
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Aug 14, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/537376 mentions this issue: internal/swarmclient: add a noop configuration for RPC credentials.

gopherbot pushed a commit to golang/build that referenced this issue Oct 24, 2023
@cagedmantis
internal/swarmclient: add a noop configuration for RPC credentials.
a966970 
The swarmclient requires the per RPC credentials function to be set
even though it isn't used.

For golang/go#61773

Change-Id: I5fe81ef853bfb400212ecfecef3890b53305fb80
Reviewed-on: https://go-review.googlesource.com/c/build/+/537376
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/540215 mentions this issue: internal/gomote, cmd/gomoteserver: use buildbucket for builder types

gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2023
@cagedmantis @gopherbot
internal/gomote, cmd/gomoteserver: use buildbucket for builder types
f44ba66 
This change uses the build bucket API to retrieve builder data instead
of the configuration server API. It also changes the desired builder
type to the test only builders.

This also changes the script used to start the buildlet in a swarming
task. Python is already installed on all of the builders. Writing an
OS agnostic script to start the buildlet is preferred in Python.

For golang/go#63781
For golang/go#61773

Change-Id: I6137eac9f0525b6496b45b3ee46e46afaf34afa1
Reviewed-on: https://go-review.googlesource.com/c/build/+/540215
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot