Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: enable gomote for LUCI bots #61772

Closed
7 of 37 tasks
cagedmantis opened this issue Aug 4, 2023 · 16 comments
Closed
7 of 37 tasks

x/build/cmd/gomote: enable gomote for LUCI bots #61772

cagedmantis opened this issue Aug 4, 2023 · 16 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. umbrella
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Aug 4, 2023 •
edited

The migration to LUCI requires us enable gomote functionality for LUCI. This issue tracks that work.
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 4, 2023
@cagedmantis cagedmantis added this to the Backlog milestone Aug 4, 2023
@cagedmantis cagedmantis self-assigned this Aug 4, 2023
@gopherbot
Copy link

Change https://go.dev/cl/518798 mentions this issue: internal/gomote: implement list swarming bots endpoint

@gopherbot
Copy link

Change https://go.dev/cl/518797 mentions this issue: internal/swarmclient: add LUCI config client

@gopherbot
Copy link

Change https://go.dev/cl/518799 mentions this issue: cmd/gomote: list swarming builders on create

@gopherbot
Copy link

Change https://go.dev/cl/518796 mentions this issue: internal/gomote/protos: add a list swarming builders endpoint

gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/gomote/protos: add a list swarming builders endpoint
c783e11 
This change adds a GRPC endpint to the gomote server which
lists all of the LUCI swarming builders for the project. The
builders names will be used to request the types of gomote
instance requested.

Updates golang/go#61773
For golang/go#61772

Change-Id: I2c6bfb3d251967b8008ba64ee28f2e1c8472df5b
Reviewed-on: https://go-review.googlesource.com/c/build/+/518796
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/swarmclient: add LUCI config client
a8f30e9 
This change creates a LUCI config client. This client
will be used to query the LUCI configuration service.

Updates golang/go#61773
For golang/go#61772

Change-Id: I1b23facc304e8865be9c900af5b53874840fba47
Reviewed-on: https://go-review.googlesource.com/c/build/+/518797
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
internal/gomote: implement list swarming bots endpoint
8e06b07 
This change adds an endpoint to list the swarming builders which are
available for the gomote user to create and instance from.

Updates golang/go#61773
For golang/go#61772

Change-Id: Ic2bd0bb5d9b5866399370197fa543ea949addc31
Reviewed-on: https://go-review.googlesource.com/c/build/+/518798
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 14, 2023
@cagedmantis
cmd/gomote: list swarming builders on create
27b08b3 
If a create is issued without a gomote instance type, the gomote
client will query the gomote server for all available instance types.
This adds the ability to query for swarming builder types.

Updates golang/go#61773
For golang/go#61772

Change-Id: If8d9a2d6b0aa509aafd199ec140659cb7d664308
Reviewed-on: https://go-review.googlesource.com/c/build/+/518799
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link

Change https://go.dev/cl/519475 mentions this issue: cmd/gomoteserver: create gomote server

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Aug 15, 2023
gopherbot pushed a commit to golang/build that referenced this issue Aug 16, 2023
@cagedmantis @gopherbot
cmd/gomoteserver: create gomote server
e0cbf39 
This change copies the gomote server functionality from the coordinator
into a new server. This will require refactoring after this initial CL.

Updates golang/go#61912
For golang/go#61772

Change-Id: I25ef657f4512d034bdc3e98bf2718e5e768be1c4
Reviewed-on: https://go-review.googlesource.com/c/build/+/519475
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/520239 mentions this issue: cmd/gomoteserver: add files to build gomote server

@cagedmantis cagedmantis mentioned this issue Aug 17, 2023
Closed
gopherbot pushed a commit to golang/build that referenced this issue Aug 17, 2023
@cagedmantis @gopherbot
cmd/gomoteserver: add files to build gomote server
1e72cea 
This change adds files to build the gomote server. There
is a small fix on a flag description in the actual gomote
server itself.

Updates golang/go#61912
For golang/go#61772

Change-Id: If424342975bf210cd27d8b18879210eac53ea8fb
Reviewed-on: https://go-review.googlesource.com/c/build/+/520239
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/520655 mentions this issue: cmd/gomoteserver: add Makefile and associated cloud build config

@gopherbot
Copy link

Change https://go.dev/cl/520695 mentions this issue: deploy, cmd/gomoteserver: add the Kubernetes configuration

gopherbot pushed a commit to golang/build that referenced this issue Aug 17, 2023
@cagedmantis @gopherbot
cmd/gomoteserver: add Makefile and associated cloud build config
bf0edf0 
This change adds the last required configuration files
required for building the gomote server.

Updates golang/go#61912
For golang/go#61772

Change-Id: I625a4d265260eb95f1a37de8c5b3596b1c2fd7c8
Reviewed-on: https://go-review.googlesource.com/c/build/+/520655
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Sep 6, 2023
@cagedmantis
deploy, cmd/gomoteserver: add the Kubernetes configuration
245708a 
This change adds the Kubernetes configuration changes necessary
for the gomote server to be deployed in the cluster. It creates
a new ingress for the gomote server. It also adds an external
IP address for the gomote ssh functionality.

Updates golang/go#61912
For golang/go#61772

Change-Id: If821ff368bbd025a566b04f2d9779f2a12ff4cb2
Reviewed-on: https://go-review.googlesource.com/c/build/+/520695
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/537655 mentions this issue: internal/task: update swarming package version

gopherbot pushed a commit to golang/build that referenced this issue Oct 25, 2023
@cagedmantis @gopherbot
internal/task: update swarming package version
88128dd 
This change updates the swarming package version and updates any
required changes because of the new package version. The new version
is required for certain gomote development features.

For golang/go#61772

Change-Id: I6ff04a9f3b0c4ae5047939a979b22ec159f11449
Reviewed-on: https://go-review.googlesource.com/c/build/+/537655
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link

Change https://go.dev/cl/538676 mentions this issue: buildenv, cmd/gomoteserver: add LUCI project configuration

gopherbot pushed a commit to golang/build that referenced this issue Oct 31, 2023
@cagedmantis @gopherbot
buildenv, cmd/gomoteserver: add LUCI project configuration
3403d10 
This change adds the configuration for the LUCI project gomote GCS
bucket.

For golang/go#61772

Change-Id: Ibfab47abae3d43831ad22d1076aaedd0165fd26d
Reviewed-on: https://go-review.googlesource.com/c/build/+/538676
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/539416 mentions this issue: main.star: grant gomoteserver the ability to manage builds

gopherbot pushed a commit to golang/build that referenced this issue Nov 2, 2023
@cagedmantis @gopherbot
main.star: grant gomoteserver the ability to manage builds
e7f1ebd 
For golang/go#61772

Change-Id: I65fc71f31e9914742b2b2db670f8203d387feac3
Reviewed-on: https://go-review.googlesource.com/c/build/+/539416
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@Oguidan
Copy link

Oguidan commented Dec 21, 2023 •
edited

@cagedmantis what is LUCI. I want to help you in this task and learn also please.

@cagedmantis
Copy link
Contributor Author

@Oguidan Hi! The Go team is migrating the build infrastructure to the infra developed by the Chrome team. That infra is called LUCI. I don't think this would be the best task to learn from. But I can certainly point you in the right direction if you are interested.

@Oguidan
Copy link

Oguidan commented Jan 3, 2024

Yes @cagedmantis I will love that. If you can also mentor me to be a better contributor like you I would be happy.

@cagedmantis
Copy link
Contributor Author

@Oguidan I think moving this conversation off of the issue tracker might be a good idea. To start contributing.https://go.dev/doc/contribute#where explains some of the common information for looking for initial ways to contribute. Find an area you are interested and can contribute in and then get comfortable with that portion of the code base.

@cagedmantis
Copy link
Contributor Author

The work required for this issue has been completed.

@cagedmantis cagedmantis mentioned this issue Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. umbrella
Projects
Go Release
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @gopherbot @Oguidan