Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: VERSION file CL submission race affecting RCs after early thaw #61713

Open
dmitshur opened this issue Aug 2, 2023 · 2 comments
Open

x/build/cmd/relui: VERSION file CL submission race affecting RCs after early thaw #61713

dmitshur opened this issue Aug 2, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.23

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 2, 2023

RC releases that happen after early thaw have a race: the relui workflow reads the head of the release branch at the start and does its work. During early thaw, the latest release branch is open to all approvers, and if any CL is submitted before the VERSION CL is, they'd need to be temporarily reverted and resent, or the relui workflow would need to be started anew.

So we need to temporarily freeze the release branch during such RC releases. This is the tracking issue for that.

CC @golang/release.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 2, 2023
@dmitshur dmitshur added this to the Go1.22 milestone Aug 2, 2023
@heschi
Copy link
Contributor

heschi commented Aug 2, 2023

I think it might be fine, and certainly easier, to do the VERSION CL submission at the beginning of the workflow for RCs. For more sensitive releases we don't want to do externally-visible stuff until the release is ready to ship, but RCs are lower stakes.

@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 2, 2023

That might be fine. It brings about some inflexibility and complexity overhead, too, which I imagine you're taking into account.

@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Status: Planned
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi